SDL2, missing MIR LDFLAGS

[SDLBugzilla]

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 2.0.5
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2016-12-30 21:34:16 +0000, Gianfranco wrote:

Hello, patch attached:

Description: Add missing MIR libraries
Author: Gianfranco Costamagna locutusofborg@debian.org

--- libsdl2-2.0.5+dfsg1.orig/configure.in
+++ libsdl2-2.0.5+dfsg1/configure.in
@@ -1334,6 +1334,7 @@ AC_HELP_STRING([--enable-mir-shared], [d
test x$xkbcommon_lib != x; then
echo "-- dynamic libmirclient -> $mirclient_lib"
echo "-- dynamic libxkbcommon -> $xkbcommon_lib"

•            EXTRA_LDFLAGS="$EXTRA_LDFLAGS $MIR_LIBS"
             AC_DEFINE_UNQUOTED(SDL_VIDEO_DRIVER_MIR_DYNAMIC, "$mirclient_lib", [ ])
             AC_DEFINE_UNQUOTED(SDL_VIDEO_DRIVER_MIR_DYNAMIC_XKBCOMMON, "$xkbcommon_lib", [ ])
             SUMMARY_video="${SUMMARY_video} mir(dynamic)"
  

you can even probably merge the two EXTRA_LDFLAGS in true and false branches.

thanks for considering it

On 2016-12-31 18:35:30 +0000, Sam Lantinga wrote:

Dynamically loading MIR is supposed to remove runtime dependencies on the MIR libraries. What is failing to link in the dynamic loading case?

On 2017-01-02 17:17:09 +0000, Gianfranco wrote:

Hello, this is the failure I got

https://launchpadlibrarian.net/300679206/buildlog_ubuntu-zesty-amd64.libsdl2_2.0.5+dfsg1-2ubuntu1_BUILDING.txt.gz

CC build/SDL_test_log.o
CC build/SDL_test_md5.o
CC build/SDL_test_random.o
CC build/wayland-protocol.lo
CC build/relative-pointer-unstable-v1-protocol.lo
CC build/pointer-constraints-unstable-v1-protocol.lo
CC build/SDL.lo
AR build/libSDL2main.a
ar: u' modifier ignored since D' is the default (see U') RANLIB build/libSDL2main.a AR build/libSDL2_test.a ar: u' modifier ignored since D' is the default (see U')
RANLIB build/libSDL2_test.a
LTLINK build/libSDL2.la
build/.libs/SDL_mirvideo.o: In function MIR_InitDisplayFromOutput': ././src/video/mir/SDL_mirvideo.c:258: undefined reference to mir_output_get_current_mode'
collect2: error: ld returned 1 exit status
Makefile:147: recipe for target 'build/libSDL2.la' failed
make[1]: *** [build/libSDL2.la] Error 1
make[1]: Leaving directory '/<>/libsdl2-2.0.5+dfsg1'
dh_auto_build: make -j4 returned exit code 2
debian/rules:42: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

On 2017-01-02 18:30:55 +0000, Sam Lantinga wrote:

This should be fixed, thanks!
https://hg.libsdl.org/SDL/rev/3034ea08d805

On 2017-01-02 20:19:51 +0000, Brandon Schaefer wrote:

Yup, my mistake there. Thanks!