Wayland: send normalized coordinates in touch inputs events #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flibitijibibo
approved these changes
May 5, 2021
|
I know I'm a bit late, but just for the reference:
FWIW this doesn't even apply to most compositors, since the changed code is part of a Qt-specific protocol extension, which I believe is only used by Sailfish (and maybe Ubuntu Touch?) these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On wayland systems, this will send x,y coordinates in
SDL_TouchFingerEventnormalised to [0..1] instead of window coordinates.Description
According to https://wiki.libsdl.org/SDL_TouchFingerEvent, the
SDL_TouchFingerEvent, the x,y coordinates should be normalised to [0..1]. This wasn't the case on wayland clients. Therefore, this merge request fixes that.Games and applications using SDL, running with a wayland compositor and working around this issue will break on touch input if this gets merged. I haven't accounted for that within this merge request, I don't know if I should and I don't know how I should. Suggestions are welcome.
Tested on SailfishOS running the Lipstick wayland compositor. Could anyone verify this on other wayland compositors with touch input?
Existing Issue(s)
Resolves #4361