Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native midi music disabled if timidity available #35

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Native midi music disabled if timidity available #35

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

@SDLBugzilla SDLBugzilla commented Feb 11, 2021

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 1.2.8
Reported for operating system, platform: Linux, All

Comments on the original bug report:

On 2007-10-27 04:52:36 +0000, Patrice Mandin wrote:

Hello,

in music.c, line 461:
native_midi_ok = !timidity_ok;

It means that you can't use native midi if timidity is ok and available, even if you set the SDL_NATIVE_MUSIC environment variable (as written in native_midi_gpl/README). It would be nice to be able to test either output without having to recompile with one or the other disabled.

On 2007-10-27 05:12:28 +0000, Patrice Mandin wrote:

Simple patch:

-- music.c (revision 3451)
+++ music.c (working copy)
@@ -459,6 +459,9 @@
#ifdef USE_NATIVE_MIDI
#ifdef USE_TIMIDITY_MIDI
native_midi_ok = !timidity_ok;

  •   if (!native_midi_ok) {
    
  •           native_midi_ok = (getenv("SDL_NATIVE_MUSIC") != NULL);
    
  •   }
      if ( native_midi_ok )
    

#endif
native_midi_ok = native_midi_detect();

On 2009-10-03 02:30:03 +0000, Sam Lantinga wrote:

Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant