Native midi music disabled if timidity available

[SDLBugzilla]

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 1.2.8
Reported for operating system, platform: Linux, All

Comments on the original bug report:

On 2007-10-27 04:52:36 +0000, Patrice Mandin wrote:

Hello,

in music.c, line 461:
native_midi_ok = !timidity_ok;

It means that you can't use native midi if timidity is ok and available, even if you set the SDL_NATIVE_MUSIC environment variable (as written in native_midi_gpl/README). It would be nice to be able to test either output without having to recompile with one or the other disabled.

On 2007-10-27 05:12:28 +0000, Patrice Mandin wrote:

Simple patch:

-- music.c (revision 3451)
+++ music.c (working copy)
@@ -459,6 +459,9 @@
#ifdef USE_NATIVE_MIDI
#ifdef USE_TIMIDITY_MIDI
native_midi_ok = !timidity_ok;

•   if (!native_midi_ok) {
  

•           native_midi_ok = (getenv("SDL_NATIVE_MUSIC") != NULL);
  

•   }
    if ( native_midi_ok )
  

#endif
native_midi_ok = native_midi_detect();

On 2009-10-03 02:30:03 +0000, Sam Lantinga wrote:

Fixed, thanks!