Cut new release #39

SoapGentoo · 2018-04-23T07:37:07Z

Hi @erikd
in order to fix the resample collision problem in Gentoo, could you please issue a new tarball for libsamplerate?
Thanks!

The text was updated successfully, but these errors were encountered:

Flamefire · 2019-08-14T12:22:33Z

Please fix #5 first as the current master contains a potential out-of-bounds read: #5 (comment)

dvzrv · 2020-01-18T14:52:31Z

@erikd Hi! I package libsamplerate for Arch Linux.
It would be really awesome to have a new release of this great and integral piece of software. Are there major blockers to make this happen?

In the case of a release, would it be possible for you to add a PGP signature for the tarball?
Currently we're downloading tarballs and can't verify their authenticity and only do checksum checking.

Flamefire · 2020-01-18T16:09:03Z

Github automatically creates tarballs for tags so signing could be hard. But There is commit signing integrated with git. If a commit is signed and the git checksum matches then this should be enough

dvzrv · 2020-01-18T16:19:19Z

@Flamefire yes, signed commits and tags would also work (for me)!

SoapGentoo · 2020-01-18T17:40:58Z

@Flamefire

automatic tags are mostly useless for Autotools projects, as you need to bootstrap the tarball anyways. Which means you'll have to upload the bootstrapped tarball anyhow, and while at it, you might as well upload a detached .asc signature of the bootstrapped tarball.
because of the bootstrapped tarball, there exists an (authentication) gap between the signed commit and the actual bootstrapped tarball.

In Adplug, we have uploaded signed tarballs: https://github.com/adplug/adplug/releases/tag/adplug-2.3.1

Flamefire · 2020-01-18T18:41:08Z

True. Forgot that autotools is still used. I'm using cmake and never looked back...

evpobr · 2020-12-11T08:13:54Z

@SoapGentoo, i guess it is time for new release. Assign a date to v.0.1.10 milestone if you don't mind.

I've published release-v0.1.10 branch with updated NEWS for you.

evpobr · 2020-12-11T09:03:47Z

I guess it is actually 0.20, new src_clone () function added.

SoapGentoo · 2020-12-11T09:10:26Z

yes, we definitely need a new release of libsamplerate, the current one is massively out of date.

NancyLi1013 · 2020-12-22T09:52:11Z

@evpobr and @SoapGentoo

I'm a maintainer for vcpkg. We're waiting for the new release of libsamplerate that supports cmake targets. Could you please help confirm when the next release will be ready?

Thanks in advance.

Be-ing · 2021-01-15T20:26:09Z

Ping @evpobr. I am also running into trouble using libsamplerate with vcpkg on macOS. The build was fixed by #81 which was merged 1.5 years ago but there has been no release since then. For now I am hacking around this by using master with vcpkg. The build fails with:

[1/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_zoh.o -MF CMakeFiles/libsamplerate-0.dir/src_zoh.o.d -o CMakeFiles/libsamplerate-0.dir/src_zoh.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c
FAILED: CMakeFiles/libsamplerate-0.dir/src_zoh.o 
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_zoh.o -MF CMakeFiles/libsamplerate-0.dir/src_zoh.o.d -o CMakeFiles/libsamplerate-0.dir/src_zoh.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
                (       "fctiw  %1, %1\n\t"
                        ^
<inline asm>:1:2: note: instantiated into assembly here
        fctiw   %st, %st
        ^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
                (       "fctiw  %1, %1\n\t"
                                        ^
<inline asm>:2:2: note: instantiated into assembly here
        stfd    %st, -16(%rbp)
        ^~~~
2 errors generated.
[2/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_linear.o -MF CMakeFiles/libsamplerate-0.dir/src_linear.o.d -o CMakeFiles/libsamplerate-0.dir/src_linear.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c
FAILED: CMakeFiles/libsamplerate-0.dir/src_linear.o 
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_linear.o -MF CMakeFiles/libsamplerate-0.dir/src_linear.o.d -o CMakeFiles/libsamplerate-0.dir/src_linear.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
                (       "fctiw  %1, %1\n\t"
                        ^
<inline asm>:1:2: note: instantiated into assembly here
        fctiw   %st, %st
        ^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
                (       "fctiw  %1, %1\n\t"
                                        ^
<inline asm>:2:2: note: instantiated into assembly here
        stfd    %st, -16(%rbp)
        ^~~~
2 errors generated.
[3/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/samplerate.o -MF CMakeFiles/libsamplerate-0.dir/samplerate.o.d -o CMakeFiles/libsamplerate-0.dir/samplerate.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c
FAILED: CMakeFiles/libsamplerate-0.dir/samplerate.o 
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/samplerate.o -MF CMakeFiles/libsamplerate-0.dir/samplerate.o.d -o CMakeFiles/libsamplerate-0.dir/samplerate.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c:16:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
                (       "fctiw  %1, %1\n\t"
                        ^
<inline asm>:1:2: note: instantiated into assembly here
        fctiw   %st, %st
        ^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c:16:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
                (       "fctiw  %1, %1\n\t"
                                        ^
<inline asm>:2:2: note: instantiated into assembly here
        stfd    %st, -16(%rbp)
        ^~~~
2 errors generated.
[4/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_sinc.o -MF CMakeFiles/libsamplerate-0.dir/src_sinc.o.d -o CMakeFiles/libsamplerate-0.dir/src_sinc.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c
FAILED: CMakeFiles/libsamplerate-0.dir/src_sinc.o 
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_sinc.o -MF CMakeFiles/libsamplerate-0.dir/src_sinc.o.d -o CMakeFiles/libsamplerate-0.dir/src_sinc.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
                (       "fctiw  %1, %1\n\t"
                        ^
<inline asm>:1:2: note: instantiated into assembly here
        fctiw   %st, %st
        ^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
                (       "fctiw  %1, %1\n\t"
                                        ^
<inline asm>:2:2: note: instantiated into assembly here
        stfd    %st, -16(%rbp)
        ^~~~
2 errors generated.
ninja: build stopped: subcommand failed.

Thanks for your work here and with libsndfile. ❤️

evpobr · 2021-01-16T05:24:08Z

Hi, @Be-ing. I guess Vcpkg port is outdated.

evpobr · 2021-01-16T05:28:37Z

yes, we definitely need a new release of libsamplerate, the current one is massively out of date.

@SoapGentoo, how about a new release, is there a planned timeline? Or did I misunderstand you and you will only release libsndfile?

evpobr · 2021-01-16T05:33:13Z

Branch: https://github.com/libsndfile/libsamplerate/commits/release-v0.2.0

SoapGentoo · 2021-01-16T10:16:13Z

@evpobr anything left we have to do for this release?

evpobr · 2021-01-16T11:31:03Z

Wait a little.

evpobr · 2021-01-16T11:42:11Z

@SoapGentoo , i guess it is ready. You need to update NEWS and add entry to history.md.

Be-ing · 2021-01-21T00:27:08Z

ping @SoapGentoo could you take care of updating NEWS and history.md and making the release?

SoapGentoo · 2021-01-21T10:32:15Z

@what else do I need to put in NEWS (maybe I'm missing something here)?

evpobr · 2021-01-21T10:37:18Z

I guess no. Just add release date to NEWS and release entry to history.md.

SoapGentoo · 2021-01-21T11:53:28Z

@evpobr I found another bug in the Automake testing harness. Here's my suggestion: let's (fast-forward) merge your stuff into master and we cut releases from master instead? Then I can add my fix to master too, and we then cut 0.2.0?

evpobr · 2021-01-21T12:04:37Z

Of course, do what you need to do with this branch.

SoapGentoo · 2021-01-21T14:11:16Z

Thanks everyone, we're done here, just cut 0.2.0 and uploaded it.

evpobr · 2021-01-21T14:26:38Z

@SoapGentoo , Windows packages, built with CMake and Visual Studio 2019.

libsamplerate-0.2.0-win64.zip
libsamplerate-0.2.0-win32.zip

SoapGentoo · 2021-01-21T14:27:50Z

@evpobr want me to sign them as well?

evpobr · 2021-01-21T14:31:07Z

@evpobr want me to sign them as well?

Yes.

evpobr · 2021-01-21T14:31:19Z

A small note about tags. We will add the v prefix before the version tag? I mean right now we have ' v0.1.9` and '0.2.0'. I think you need to choose one style.

SoapGentoo · 2021-01-21T14:34:32Z

I'd prefer changing it all to X.Y.Z instead of vX.Y.Z, mainly because the latter is a Github thing and makes generating automatic links to the releases more annoying (and also isn't included in the actual filename of the tarballs). But if you prefer v I'll do that too.

evpobr · 2021-01-21T14:38:00Z

I think it's more a matter of taste. Let it be without a prefix.

SoapGentoo · 2021-01-21T14:50:58Z

@evpobr everything cleaned up, close if you're happy

Be-ing · 2021-01-21T18:18:15Z

vcpkg update PR: microsoft/vcpkg#15797

Switch to new github organization for url and source. The original author transferred the repository to the org: libsndfile/libsamplerate#39 Add PGP public key of current maintainer. Switch to cmake as build system. git-svn-id: file:///srv/repos/svn-packages/svn@407491 eb2447ed-0c53-47e4-bac8-5bc4a241df78

Switch to new github organization for url and source. The original author transferred the repository to the org: libsndfile/libsamplerate#39 Add PGP public key of current maintainer. Switch to cmake as build system. git-svn-id: file:///srv/repos/svn-community/svn@845552 9fca08f4-af9d-4005-b8df-a31f2cc04f65

Flamefire mentioned this issue Aug 14, 2019

[discussion] next release soon ? #58

Closed

NancyLi1013 mentioned this issue Dec 14, 2020

[libsamplerate] CMake targets are missing microsoft/vcpkg#15064

Closed

SoapGentoo closed this as completed Jan 21, 2021

evpobr reopened this Jan 21, 2021

evpobr closed this as completed Jan 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cut new release #39

Cut new release #39

SoapGentoo commented Apr 23, 2018

Flamefire commented Aug 14, 2019

dvzrv commented Jan 18, 2020

Flamefire commented Jan 18, 2020

dvzrv commented Jan 18, 2020

SoapGentoo commented Jan 18, 2020

Flamefire commented Jan 18, 2020

evpobr commented Dec 11, 2020 •

edited

evpobr commented Dec 11, 2020

SoapGentoo commented Dec 11, 2020

NancyLi1013 commented Dec 22, 2020

Be-ing commented Jan 15, 2021 •

edited

evpobr commented Jan 16, 2021

evpobr commented Jan 16, 2021

evpobr commented Jan 16, 2021

SoapGentoo commented Jan 16, 2021

evpobr commented Jan 16, 2021

evpobr commented Jan 16, 2021

Be-ing commented Jan 21, 2021 •

edited

SoapGentoo commented Jan 21, 2021 •

edited

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

evpobr commented Jan 21, 2021 •

edited

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

Be-ing commented Jan 21, 2021

Cut new release #39

Cut new release #39

Comments

SoapGentoo commented Apr 23, 2018

Flamefire commented Aug 14, 2019

dvzrv commented Jan 18, 2020

Flamefire commented Jan 18, 2020

dvzrv commented Jan 18, 2020

SoapGentoo commented Jan 18, 2020

Flamefire commented Jan 18, 2020

evpobr commented Dec 11, 2020 • edited

evpobr commented Dec 11, 2020

SoapGentoo commented Dec 11, 2020

NancyLi1013 commented Dec 22, 2020

Be-ing commented Jan 15, 2021 • edited

evpobr commented Jan 16, 2021

evpobr commented Jan 16, 2021

evpobr commented Jan 16, 2021

SoapGentoo commented Jan 16, 2021

evpobr commented Jan 16, 2021

evpobr commented Jan 16, 2021

Be-ing commented Jan 21, 2021 • edited

SoapGentoo commented Jan 21, 2021 • edited

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

evpobr commented Jan 21, 2021 • edited

SoapGentoo commented Jan 21, 2021

evpobr commented Jan 21, 2021

SoapGentoo commented Jan 21, 2021

Be-ing commented Jan 21, 2021

evpobr commented Dec 11, 2020 •

edited

Be-ing commented Jan 15, 2021 •

edited

Be-ing commented Jan 21, 2021 •

edited

SoapGentoo commented Jan 21, 2021 •

edited

evpobr commented Jan 21, 2021 •

edited