New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access to Embedded WAV/AIFF Metadata Inside FLAC #59
Comments
|
Had a look at this. Currently looks like there is a bug in libFLAC with respect to application metadata. |
|
Scratch that. I was misusing the FLAC metadata API (which is a little too easy to misuse). |
|
Gah! This is getting complicated real fast. I can grab the application metadata chunk from FLAC, but I can't just pass it to the WAV header parse routines because they expect a file descriptor and I've got a pointer to a block of memory. The solution is some significant refactoring as follows:
|
|
Not sure if this is still on the wishlist, but I wrote some code to get this data out of a file using the FLAC api |
As an alternative, can we possibly read the whole binary chunk in one go, and then parse it with |
|
Please fix this in the lib, so that programs like linuxsampler will be able to honor 'smpl' chunk loops. Any chance of this happening soon, or should they pursue a workaround like sfztools/sfizz#242 ? |
AFAICS changing wav_read_smpl_chunk() is probably not necessary. It might make sense simply passing a temporary copy of SF_PRIVATE structure to wav_read_smpl_chunk() with SF_PRIVATE->vio being filled with custom seek/read functions which read from memory instead of doing real file I/O. |
|
@erikd Would you mind sharing whatever you already had on this issue, so that we can complete your patch to fit into libsndfile appropriately? That would save us some work and would help to bring this issue forward. |
|
@zodf0055980 and @evpobr helped improve handling of SMPL chunks in WAV files. Perhaps they can help suggest how to implement this feature? |
|
Soppy, no plans yet. But we will be happy to accept the patch. |
|
Oct. 19, 2022 - Version 12.49 release of exiftool now parses .wav and .flac loop data! Usage: Output: |
|
Good. Can we close it now? |
|
@evpobr ah apologies for not providing context. Exiftool is primarily used for inspecting files metadata after files have already been created. Adding support in libsndfile would ensure creation of audio files with the correct metadata. Exiftool can help whoever is working on this feature to validate it functions correctly. |
I have lots of wav/aiff files with embedded sample playback informations
that I read using SFC_GET_LOOP_INFO and SFC_GET_INSTRUMENT.
I would like that once those file are reencoded in flac (using --keep-foreign-metadata)
still be able to retrieve those informations as well as getting custom chunk
using sf_get_chunk_size and sf_get_chunk_data
The text was updated successfully, but these errors were encountered: