Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API headers declare types incorrectly #93

Closed
rosshemsley opened this issue Mar 2, 2017 · 0 comments

Comments

@rosshemsley
Copy link

commented Mar 2, 2017

The types declared in the C API headers don't match the types used in the definitions.

This can cause unexpected runtime errors for users of the library, since they link against headers that do not correspond to what is in the library (index becomes corrupted)

This would not normally compile, but the headers are not included during compilation.

I created a PR: #92 that fixes this issue for sidx_api.h. It may be worth auditing the other files, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.