New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file resource's POSIX inline backend. #2

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
2 participants
@pocket7878
Contributor

pocket7878 commented Aug 30, 2017

@pocket7878

This comment has been minimized.

Show comment
Hide comment
@pocket7878

pocket7878 Aug 30, 2017

Contributor

@mizzy
Some methods needs platform specific handling (is_immutable, is_mounted ...etc).
Should we leave them with default method to return Err?

Contributor

pocket7878 commented Aug 30, 2017

@mizzy
Some methods needs platform specific handling (is_immutable, is_mounted ...etc).
Should we leave them with default method to return Err?

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Aug 30, 2017

Member

Thanks for your great contribution!

Should we leave them with default method to return Err?

Yes, please.

Member

mizzy commented Aug 30, 2017

Thanks for your great contribution!

Should we leave them with default method to return Err?

Yes, please.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Aug 30, 2017

Member

Or it is OK leaving them umplemented.

Member

mizzy commented Aug 30, 2017

Or it is OK leaving them umplemented.

@pocket7878 pocket7878 changed the title from [WIP] Implement file resource's POSIX inline backend. to Implement file resource's POSIX inline backend. Sep 2, 2017

@pocket7878

This comment has been minimized.

Show comment
Hide comment
@pocket7878

pocket7878 Sep 2, 2017

Contributor

@mizzy Thank you for your review. I just finished rough implementation.
I wonder if I should leave content_as_{json, yaml} to client-side.

Contributor

pocket7878 commented Sep 2, 2017

@mizzy Thank you for your review. I just finished rough implementation.
I wonder if I should leave content_as_{json, yaml} to client-side.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Sep 3, 2017

Member

I wonder if I should leave content_as_{json, yaml} to client-side.

I think so, too.

Member

mizzy commented Sep 3, 2017

I wonder if I should leave content_as_{json, yaml} to client-side.

I think so, too.

@pocket7878

This comment has been minimized.

Show comment
Hide comment
@pocket7878

pocket7878 Sep 3, 2017

Contributor

Removed contents_as_{json, yaml}. And squashed into single commit.

Contributor

pocket7878 commented Sep 3, 2017

Removed contents_as_{json, yaml}. And squashed into single commit.

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Sep 6, 2017

Member

Thanks a lot!

Member

mizzy commented Sep 6, 2017

Thanks a lot!

@mizzy mizzy merged commit 2330ee5 into libspecinfra:master Sep 6, 2017

@mizzy

This comment has been minimized.

Show comment
Hide comment
@mizzy

mizzy Sep 6, 2017

Member

Released as v0.3.0.

Member

mizzy commented Sep 6, 2017

Released as v0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment