Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
packet.c: improve message parsing (#402)
* packet.c: improve parsing of packets file: packet.c notes: Use _libssh2_get_string API in SSH_MSG_DEBUG/SSH_MSG_DISCONNECT. Additional uint32 bounds check in SSH_MSG_GLOBAL_REQUEST.
- Loading branch information
Showing
1 changed file
with
29 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedcbd1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like only after that commit it would be good to make new release (1.9.1?)
If may I ask on that ocation consider change tagging convention to use in tag only version because github automatically generatet tar balls are using
<repo_name>-<tag>and by this tar like https://github.com/libssh2/libssh2/archive/libssh2-1.9.0.tar.gz has base directorylibssh2-libssh2-1.9.0/.dedcbd1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,When I added this patch, the error was reported as follows: Can you tell me the reason?
15:05:53 DEBUG: packet.c: In function '_libssh2_packet_add':
15:05:53 DEBUG: packet.c:473:36: error: storage size of 'buf' isn't known
15:05:53 DEBUG: struct string_buf buf;
15:05:53 DEBUG: ^
15:05:53 DEBUG: packet.c:526:36: error: storage size of 'buf' isn't known
15:05:53 DEBUG: struct string_buf buf;