New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for Review] Add agent forwarding implementation #219

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@pkittenis
Contributor

pkittenis commented Oct 20, 2017

Hello,

This PR implements SSH agent forwarding support via libssh2_channel_request_auth_agent. It is based on Mr Hashimoto's patch in mailing list with changes/additions for correctness (primarily, the message was incorrect in the patch).

Example file has been updated to use agent auth and added to cmake list.

Also added integration test tests/test_agent_forward_succeds.c and to cmake list which is passing (needs #218 for cmake build to succeed)

Let me know if anything else needed. Agent forwarding is one of the only "core" features missing in libssh2 so would be good to get it implemented. Thanks for the awesome library.

Resolves #185

@pkittenis pkittenis changed the title from Agent fwd to Add agent forwarding implementation Oct 20, 2017

@pkittenis

This comment has been minimized.

Show comment
Hide comment
@pkittenis

pkittenis Oct 21, 2017

Contributor

Looks like there are some unrelated errors in some builds

dpkg: error processing package oracle-java9-installer (--configure):

subprocess installed post-installation script returned error exit status 1
Errors were encountered while processing:

oracle-java9-installer
Contributor

pkittenis commented Oct 21, 2017

Looks like there are some unrelated errors in some builds

dpkg: error processing package oracle-java9-installer (--configure):

subprocess installed post-installation script returned error exit status 1
Errors were encountered while processing:

oracle-java9-installer
@pkittenis

This comment has been minimized.

Show comment
Hide comment
@pkittenis

pkittenis Oct 24, 2017

Contributor

Appveyor failures also look unrelated:

Cannot open include file: 'netinet/in.h': No such file or directory and others including unistd.h which is not available on windows platforms.

Contributor

pkittenis commented Oct 24, 2017

Appveyor failures also look unrelated:

Cannot open include file: 'netinet/in.h': No such file or directory and others including unistd.h which is not available on windows platforms.

@pkittenis

This comment has been minimized.

Show comment
Hide comment
@pkittenis

pkittenis Nov 18, 2017

Contributor

Is anyone available to review this PR?

One thing that has not been tested is the behaviour with a non-OpenSSH server.

Contributor

pkittenis commented Nov 18, 2017

Is anyone available to review this PR?

One thing that has not been tested is the behaviour with a non-OpenSSH server.

@pkittenis pkittenis changed the title from Add agent forwarding implementation to [Ready for Review] Add agent forwarding implementation Dec 8, 2017

pkittenis added some commits Oct 18, 2017

Fix agent forwarding message, updated example.
Added integration test code and cmake target. Added example to cmake list.
@pkittenis

This comment has been minimized.

Show comment
Hide comment
@pkittenis

pkittenis May 11, 2018

Contributor

Latest changes: Support windows builds for agent fwd example. Appveyor tests now pass.

Contributor

pkittenis commented May 11, 2018

Latest changes: Support windows builds for agent fwd example. Appveyor tests now pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment