Do we want to fix these gcc warnings?

[karel-m]

-Wswitch-default

src/ciphers/multi2.c:96:7: error: switch missing default case [-Werror=switch-default]
       switch (n<=4 ? n : ((n-1)%4)+1) {
       ^~~~~~
src/ciphers/twofish/twofish.c:247:3: error: switch missing default case [-Werror=switch-default]
   switch (k) {
   ^~~~~~
src/hashes/tiger.c:569:5: error: switch missing default case [-Werror=switch-default]
     switch (mul) {
     ^~~~~~
src/pk/asn1/der/choice/der_decode_choice.c:51:8: error: switch missing default case [-Werror=switch-default]
        switch (list[x].type) {
        ^~~~~~
src/pk/asn1/der/custom_type/der_decode_custom_type.c:163:8: error: switch missing default case [-Werror=switch-default]
        switch (type) {
        ^~~~~~
src/pk/asn1/der/custom_type/der_encode_custom_type.c:93:8: error: switch missing default case [-Werror=switch-default]
        switch (type) {
        ^~~~~~
src/pk/asn1/der/custom_type/der_length_custom_type.c:69:8: error: switch missing default case [-Werror=switch-default]
        switch (type) {
        ^~~~~~
src/pk/asn1/der/sequence/der_decode_sequence_multi.c:52:8: error: switch missing default case [-Werror=switch-default]
        switch (type) {
        ^~~~~~
src/pk/asn1/der/sequence/der_decode_sequence_multi.c:101:8: error: switch missing default case [-Werror=switch-default]
        switch (type) {
        ^~~~~~

-Wswitch-enum

src/pk/asn1/der/sequence/der_sequence_free.c: In function ‘der_sequence_free’:
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_EOL’ not handled in switch [-Werror=switch-enum]
       switch (in->type) {
       ^~~~~~
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_BOOLEAN’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_SHORT_INTEGER’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_BIT_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_OCTET_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_NULL’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_OBJECT_IDENTIFIER’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_IA5_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_PRINTABLE_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_UTF8_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_UTCTIME’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_CHOICE’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_SEQUENCE’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_SET’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_RAW_BIT_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_TELETEX_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_GENERALIZEDTIME’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_free.c:46:7: error: enumeration value ‘LTC_ASN1_CUSTOM_TYPE’ not handled in switch [-Werror=switch-enum]

src/pk/asn1/der/sequence/der_sequence_shrink.c: In function ‘der_sequence_shrink’:
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_EOL’ not handled in switch [-Werror=switch-enum]
       switch (in->type) {
       ^~~~~~
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_BOOLEAN’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_INTEGER’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_SHORT_INTEGER’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_BIT_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_OCTET_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_NULL’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_OBJECT_IDENTIFIER’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_IA5_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_PRINTABLE_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_UTF8_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_UTCTIME’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_CHOICE’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_SETOF’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_RAW_BIT_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_TELETEX_STRING’ not handled in switch [-Werror=switch-enum]
src/pk/asn1/der/sequence/der_sequence_shrink.c:34:7: error: enumeration value ‘LTC_ASN1_GENERALIZEDTIME’ not handled in switch [-Werror=switch-enum]

-Wmissing-noreturn

UPDATE: fixed by #428

-Wmissing-prototypes (some functions should be decared as static)

UPDATE: fixed by #428

-Wmissing-declarations (similar to previous one)

UPDATE: fixed by #428

[karel-m]

-Wunused-macros

UPDATE: fixed by #444

[sjaeckel]

Patch looks like this: d77db7c Should I create PR?

👍

[sjaeckel]

I don't think those enum-related warnings should be fixed.