remove OPT_CAST #177
Merged
remove OPT_CAST #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nijtmans
approved these changes
Mar 26, 2019
Collaborator
nijtmans
left a comment
nijtmans
left a comment
There was a problem hiding this comment.
I'm OK with this change (FWIW). To me the OPT_CAST() macro raises more questions than that it solves.
sjaeckel
approved these changes
Mar 29, 2019
The explicit cast does not hurt in C. Furthermore the explicit cast is needed if tommath is compiled as C with strict warning settings.
sjaeckel
force-pushed
the
remove-opt-cast
branch
from
9296970 to
28e6177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit cast does not hurt in C. Furthermore the explicit cast is needed
if tommath is compiled as C with strict warning settings.