enable MP_PRIVATE (visibility=hidden) #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minad
force-pushed
the
private-symbols
branch
from
be03523 to
2e48264
Compare
Collaborator
|
Well, I took the liberty to fix the mingw build of libtommath.dll to respect the privacy too: The GCC attributes don't work in this situation, instead the tommath.def file needs to be used to indicate which symbols are exported. Apart from that: Looks good! |
nijtmans
approved these changes
Oct 18, 2019
Member
Author
|
@nijtmans thanks! |
sjaeckel
force-pushed
the
private-symbols
branch
from
00deac5 to
3eaa268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.2 we had MP_PRIVATE disabled by default. This should be changed now.