Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd FreeBSD/aarch64 support #83
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
djwatson
Jul 30, 2018
Member
This patch seems to implement _UPT_access_fpreg for aarch64, is that correct?
It looks fine to me for that, but your PR title and description seem to be completely unrelated to what the patch is doing.
|
This patch seems to implement _UPT_access_fpreg for aarch64, is that correct? It looks fine to me for that, but your PR title and description seem to be completely unrelated to what the patch is doing. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
myfreeweb
Jul 30, 2018
Contributor
@djwatson that's one part of it. (yeah I didn't even notice that wasn't OS-specific) there's also aarch64 support in _UCD_access_reg_freebsd.c, and unw_fpsimd_context_t instead of using that struct directly from Linux headers to make it work on FreeBSD
|
@djwatson that's one part of it. (yeah I didn't even notice that wasn't OS-specific) there's also aarch64 support in |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Gotchya. Updating the commit message and merging, thanks. |
myfreeweb commentedJul 18, 2018
I'm actually quite confused about how aarch64 contexts are implemented…
unw_tdep_context_t/unw_sigcontext, a private copy of Linux structsunw_tdep_getcontextmacro??fpsimd_contextfrom Linux system headers??So I added an internal Linux-compatible fpsimd struct and that compiles…
I'm not sure how to properly test,
make checktries to link the library twice for some reason:Tried to run something manually:
run-coredump-unwind(and-mdi) expect GNU binaries:mktemp: illegal option -- -test-ptrace-miscreturnssum = 0test-strerrorandtest-proc-infoexit 0 without printing anythingforkersegfaults instrtol_lip = 20394, sp = ffffffffdaf0) and does not segfault! :)