Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multline log messages #24

Merged
merged 1 commit into from Dec 9, 2019
Merged

Conversation

bashtanov
Copy link
Contributor

@bashtanov bashtanov commented Oct 4, 2019

currently they are lost

@bashtanov
Copy link
Contributor Author

@bashtanov bashtanov commented Oct 4, 2019

@petere when a multiline message is to be logged an empty one appears instead. This is to fix it.

I found that when trying to apply https://github.com/pgbouncer/pgbouncer/blob/master/test/asynctest.c to pgbouncer/pgbouncer#420.

I would appreciate if you could have a look.

@petere
Copy link
Contributor

@petere petere commented Oct 5, 2019

Where are multiline log messages used?

@bashtanov
Copy link
Contributor Author

@bashtanov bashtanov commented Oct 7, 2019

here the reason may come from libpq and can be multiline, e.g. like this:

2019-10-04 17:14:58.925 BST [5170] DEBUG disconnect because: PQconnectStart: could not connect to server: Cannot assign requested address
 		Is the server running on host "127.0.0.1" and accepting
 		TCP/IP connections on port 7000?

Not sure if pgbouncer itself can attempt emitting multiline messages.

@petere petere merged commit 527924f into libusual:master Dec 9, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants