Skip to content
Permalink
Branch: v1.x
Commits on Aug 9, 2019
  1. win: remove try-except outside MSVC

    Crunkle authored and cjihrig committed Aug 8, 2019
    Fixes: #2407
    PR-URL: #2412
    Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: João Reis <reis@janeasystems.com>
Commits on Aug 7, 2019
  1. test: fix test runner on MinGW

    Crunkle authored and cjihrig committed Aug 7, 2019
    MinGW does not export the _set_fmode function via its
    libmsvcrt.a import library unless on an ARM platform. This
    causes the test target build to fail without manually
    adjusting the link parameters.
    
    It is safe to assume that _fmode is available in all stable
    releases, and it should be preferred unless using MSVC. This
    is unrelated to #2407, but when both are fixed, MinGW builds
    should complete successfully.
    
    PR-URL: #2411
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
You can’t perform that action at this time.