Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip OSX TTY select test if /dev/tty cannot be opened #123

Merged
merged 1 commit into from Jan 7, 2015
Merged

test: skip OSX TTY select test if /dev/tty cannot be opened #123

merged 1 commit into from Jan 7, 2015

Conversation

saghul
Copy link
Member

@saghul saghul commented Jan 7, 2015

@bnoordhuis
Copy link
Member

Long commit line but otherwise LGTM.

@saghul
test: skip TTY select test if /dev/tty can't be opened
72e4b5a 
PR-URL: #123
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@saghul saghul merged commit 72e4b5a into libuv:v1.x Jan 7, 2015
ebraminio referenced this pull request in ebraminio/libuv Jan 12, 2015
Revert 0d435a5 and fix joyent#123
6887679
ebraminio referenced this pull request in ebraminio/libuv Jan 12, 2015
@ebraminio
Revert 0d435a5 and fix joyent#123
f57b4eb
@saghul saghul deleted the tty_select_test branch January 19, 2015 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saghul @bnoordhuis