Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix: call setgoups before calling setuid/setgid #215

Merged
merged 1 commit into from Feb 20, 2015

Conversation

saghul
Copy link
Member

@saghul saghul commented Feb 19, 2015

Backported from v1.x (66ab389)

R=@bnoordhuis
R=@tjfontaine

@bnoordhuis
Copy link
Member

LGTM

@piscisaureus
Copy link
Contributor

Good catch. Security issue?

Backported from v1.x (66ab389)

PR-URL: libuv#215
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@saghul saghul merged commit 2773e11 into libuv:v0.10 Feb 20, 2015
@saghul
Copy link
Member Author

saghul commented Feb 20, 2015

@piscisaureus yes, looks like I forgot to backport the fix to 0.10 branch back in the day :-S

@saghul saghul deleted the setgroups_backport branch May 26, 2015 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants