Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unix,win: add uv_fs_statfs() #2396

Merged
merged 1 commit into from Aug 1, 2019
Merged

unix,win: add uv_fs_statfs() #2396

merged 1 commit into from Aug 1, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 29, 2019 •
edited

Fixes: #2386

@saghul
Copy link
Member

saghul commented Jul 30, 2019

Looking good so far!

bnoordhuis
bnoordhuis approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIX side LGTM!

@santigimeno
Copy link
Member

LGTM

@cjihrig cjihrig force-pushed the statfs branch 3 times, most recently from 2c2df83 to 4f9bd65 Compare July 31, 2019 05:51
@cjihrig cjihrig changed the title WIP: unix,win: add uv_fs_statfs() unix,win: add uv_fs_statfs() Jul 31, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 31, 2019

Added the rest of the missing pieces. PTAL.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1476/

@cjihrig cjihrig mentioned this pull request Jul 31, 2019
Closed
bzoz
bzoz approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjihrig
unix,win: add uv_fs_statfs()
bf86d5f 
Fixes: libuv#2386
PR-URL: libuv#2396
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 1, 2019

CI after resolving conflicts and squashing: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1478/

@cjihrig cjihrig merged commit bf86d5f into libuv:v1.x Aug 1, 2019
@cjihrig cjihrig deleted the statfs branch August 1, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@saghul saghul saghul approved these changes

@santigimeno santigimeno santigimeno approved these changes

@bzoz bzoz bzoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve disk information
5 participants
@cjihrig @saghul @santigimeno @bnoordhuis @bzoz