Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building tests on MinGW (use old fmode) #2411

Closed
wants to merge 1 commit into from

Conversation

@Crunkle
Copy link
Contributor

commented Aug 7, 2019

MinGW does not export the _set_fmode function via its libmsvcrt.a import library unless on an ARM platform. This causes the test target build to fail unless manually adjusting the link parameters - which is a nuisance.

It is safe to assume _fmode is widely available by all stable releases and that should be preferred unless using MSVC. This is unrelated to #2407 but when both are fixed, MinGW builds should complete successfully.

@cjihrig

cjihrig approved these changes Aug 7, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

CI with no apparent related failures: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1502/

@saghul

saghul approved these changes Aug 7, 2019

cjihrig added a commit that referenced this pull request Aug 7, 2019

test: fix test runner on MinGW
MinGW does not export the _set_fmode function via its
libmsvcrt.a import library unless on an ARM platform. This
causes the test target build to fail without manually
adjusting the link parameters.

It is safe to assume that _fmode is available in all stable
releases, and it should be preferred unless using MSVC. This
is unrelated to #2407, but when both are fixed, MinGW builds
should complete successfully.

PR-URL: #2411
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Landed in be1e719. Thanks!

@cjihrig cjihrig closed this Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.