Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined MCAST_* under MinGW #2461

Open
wants to merge 1 commit into
base: v1.x
from

Conversation

@Crunkle
Copy link
Contributor

commented Sep 8, 2019

Yet another missing macro required by f91702a - originates from ws2ipdef.h (here). I believe this is the best place for it to go alongside the similar others.

@bnoordhuis
Copy link
Member

left a comment

LGTM, thanks. CI: https://ci.nodejs.org/job/libuv-test-commit/1570/

You show up as "Crunkle" in the Author field. Is that how you want to be known?

@saghul
saghul approved these changes Sep 9, 2019
@Crunkle

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Yes, my username or full name are both fine; I find usernames useful for greps.

@cjihrig
cjihrig approved these changes Sep 9, 2019
saghul referenced this pull request Sep 18, 2019
udp: fix uv__udp_set_source_membership6
Use the correct socket options: `MCAST_JOIN_SOURCE_GROUP` and
`MCAST_LEAVE_SOURCE_GROUP`.
Set mreq.gsr_interface = 0 if iface_addr = NULL.

PR-URL: #2202
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.