Skip to content

Conversation

@bnoordhuis
Copy link
Member

Fixes: #1674


Works on my machine (which isn't a Windows machine. Let's see if it compiles.)

Copy link
Member

@trevnorris trevnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good. Just missing some documentation?

@bnoordhuis bnoordhuis merged commit c8a1e61 into libuv:v1.x Apr 27, 2023
@bnoordhuis bnoordhuis deleted the fix1674 branch April 27, 2023 20:13
@caobug
Copy link
Contributor

caobug commented Jul 5, 2023

The GetSystemTimePreciseAsFileTime only works on Windows 8+, do we still need to be compatible with Windows 7?

https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getsystemtimepreciseasfiletime?redirectedfrom=MSDN

@bnoordhuis
Copy link
Member Author

do we still need to be compatible with Windows 7?

No, see SUPPORTED_PLATFORMS.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: add real-time clock version of uv_hrtime()

5 participants