VideoStreaming status processing#30
Merged
Merged
Conversation
Collaborator
There was a problem hiding this comment.
It makes sense to strip off the first 5 bytes when delivering this update, but 1) this breaks any existing code that might be relying on the update's content and 2) the originator ID is lost.
I'd be open to adding an originator parameter to the callback type, maybe between status_class and event, and also making the 5-byte-offset change. That way, anything that uses the callback will break, but at least the breakage will happen at compile time.
Collaborator
There was a problem hiding this comment.
Or this may be a good time to do:
struct uvc_status_update {
enum uvc_status_class status_class;
int originator;
int event;
int selector;
enum uvc_status_attribute status_attribute;
void *data;
size_t data_len;
};
typedef void(uvc_status_callback_t)(struct uvc_status_update, void* user_ptr);
or something like that.
Contributor
Author
|
I'd suggest to add these interface-breaking changes in other pull-request |
Contributor
Author
|
Summary:
|
Collaborator
So it was! Will merge. |
ktossell
added a commit
that referenced
this pull request
Oct 28, 2015
VideoStreaming status processing
mmohsenz
pushed a commit
to mmohsenz/libuvc
that referenced
this pull request
Apr 21, 2020
Device clock frequency correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.