Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
bump min libjxl version to 0.6
  • Loading branch information
@jcupitt
jcupitt committed Oct 12, 2021
1 parent b98366f commit 21cdf22
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions configure.ac
View file
Expand Up @@ -836,9 +836,9 @@ AS_IF([test x"$with_libjxl" = x"module"],
[with_libjxl_module=no])

if test x"$with_libjxl" != x"no"; then
PKG_CHECK_MODULES(LIBJXL, libjxl_threads >= 0.3.7 libjxl >= 0.3.7,
PKG_CHECK_MODULES(LIBJXL, libjxl_threads >= 0.6 libjxl >= 0.6,
[AC_DEFINE(HAVE_LIBJXL,1,
[define if you have libjxl >= 0.3.7 installed.])
[define if you have libjxl >= 0.6 installed.])
with_libjxl=yes
AS_IF([test x"$with_libjxl_module" = x"no"],
[PACKAGES_USED="$PACKAGES_USED libjxl"])
Expand Down

5 comments on commit 21cdf22

@remicollet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this version requirement change ?

(P.S. fedora still have 0.5.x in all released versions)

@jcupitt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @remicollet,

v0.6 changed the API, so we would have needed to add a set of tests and ifdefs to support both versions. Since v0.5 has several serious security problems, we decided it was cleaner and safer to bump the minimum to 0.6.

@jcupitt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API change is here fwiw: bd8fad8

Not very interesting, but it would have required configure tests and ifdefs.

@remicollet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand... so this mean I drop support for this one until Fedora have it...

For memory https://bugzilla.redhat.com/show_bug.cgi?id=2018648

@jcupitt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think that's reasonable.

Please sign in to comment.