Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test pass in 2025 #56

Merged
merged 1 commit into from Nov 12, 2019
Merged

Make test pass in 2025 #56

merged 1 commit into from Nov 12, 2019

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Nov 10, 2019

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.

@@ -7,12 +7,12 @@ use HTTP::Request;
use HTTP::Response;

my $req = HTTP::Request->new(GET => "http://example.com");
my $resp = HTTP::Response->new(200, 'OK', ['Set-Cookie', q!a="b;c;\\"d"; expires=Fri, 06-Nov-2025 08:58:34 GMT; domain=example.com; path=/!]);
my $resp = HTTP::Response->new(200, 'OK', ['Set-Cookie', q!a="b;c;\\"d"; expires=Fri, 06-Nov-2999 08:58:34 GMT; domain=example.com; path=/!]);

This comment has been minimized.

Copy link
@oalders

oalders Nov 10, 2019

Member

Will this cause failures on systems with a year 2038 problem?

This comment has been minimized.

Copy link
@bmwiedemann

bmwiedemann Nov 10, 2019

Author Contributor

Good question. I now tested that tests still pass on i586 even in 2037.

@oalders oalders dismissed their stale review Nov 10, 2019

Dismissing as I wanted to check about 2038 problem first

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.
@bmwiedemann bmwiedemann force-pushed the bmwiedemann:master branch from 0f5df26 to eec5326 Nov 11, 2019
@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

bmwiedemann commented Nov 11, 2019

Rebased without changes to make travis tests pass

@oalders

This comment has been minimized.

Copy link
Member

oalders commented Nov 12, 2019

Thanks @bmwiedemann!

@oalders oalders merged commit 45d1468 into libwww-perl:master Nov 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@oalders

This comment has been minimized.

Copy link
Member

oalders commented Nov 12, 2019

New version has now been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.