New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for rt70740 #3

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mattlaw
Contributor

mattlaw commented Oct 17, 2011

When adding new values to a query, they would appear in reverse order
when adding from scratch, but in the specified order when adding to an
existing key.

This change makes the order items are added to the query consistent.

It also brings the interface of query_param_append in line with that of
query_param, supporting array refs as well as simple lists.

Updated tests to check for the new behaviour and use Test::More, which
was in core at the minimum perl version specified in the Makefile.PL

Do not reverse the order of new parameters
When adding new values to a query, they would appear in reverse order
when adding from scratch, but in the specified order when adding to an
existing key.

This change makes the order items are added to the query consistent.

It also brings the interface of query_param_append in line with that of
query_param, supporting array refs as well as simple lists.

Updated tests to check for the new behaviour and use Test::More, which
was in core at the minimum perl version specified in the Makefile.PL
@gisle

This comment has been minimized.

Show comment
Hide comment
@gisle

gisle Mar 30, 2012

Member

Thanks. This was applied as 63e7730 and released in URI-1.60.

Member

gisle commented Mar 30, 2012

Thanks. This was applied as 63e7730 and released in URI-1.60.

@gisle gisle closed this Mar 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment