New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t/distmanifest.t #33

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@pauloscustodio

pauloscustodio commented Nov 10, 2016

Test::DistManifest requirement was missing in Makefile.PL, causing test
t/distmanifest.t to fail. Fixed.

MANIFEST.SKIP extended to include more non-MANIFEST files, so that
t/distmanifest.t passes.

Fix t/distmanifest.t
Test::DistManifest requirement was missing in Makefile.PL, causing test
t/distmanifest.t to fail. Fixed.

MANIFEST.SKIP extended to include more non-MANIFEST files, so that
t/distmanifest.t passes.
@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Nov 10, 2016

Member

Test::DistManifest should not be in test-requires -- it should only be required for authors, not all users at install time.

Member

karenetheridge commented Nov 10, 2016

Test::DistManifest should not be in test-requires -- it should only be required for authors, not all users at install time.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Nov 10, 2016

Member

MANIFEST.SKIP only needs to contain #!include_default and a line for URI-*. But with a dzil conversion it can disappear entirely. (And for that matter, with a dzil conversion the distmanifest test can disappear too.)

Member

karenetheridge commented Nov 10, 2016

MANIFEST.SKIP only needs to contain #!include_default and a line for URI-*. But with a dzil conversion it can disappear entirely. (And for that matter, with a dzil conversion the distmanifest test can disappear too.)

@pauloscustodio

This comment has been minimized.

Show comment
Hide comment
@pauloscustodio

pauloscustodio Nov 10, 2016

Without the added lines no MANIFEST.SKIP, t/distmanifest.t was failing,
complaing of .git, blib, etc.
Is this correct?

On Thu, Nov 10, 2016 at 11:42 PM, Karen Etheridge notifications@github.com
wrote:

MANIFEST.SKIP only needs to contain #!include_default and a line for URI-*
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEUdSNNfxSmJCO-kYam8IT2xdTK-X-Eks5q86v9gaJpZM4KvQx9
.

pauloscustodio commented Nov 10, 2016

Without the added lines no MANIFEST.SKIP, t/distmanifest.t was failing,
complaing of .git, blib, etc.
Is this correct?

On Thu, Nov 10, 2016 at 11:42 PM, Karen Etheridge notifications@github.com
wrote:

MANIFEST.SKIP only needs to contain #!include_default and a line for URI-*
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEUdSNNfxSmJCO-kYam8IT2xdTK-X-Eks5q86v9gaJpZM4KvQx9
.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Nov 10, 2016

Member

If you have an updated ExtUtils::Manifest, the test should not fail.

Member

karenetheridge commented Nov 10, 2016

If you have an updated ExtUtils::Manifest, the test should not fail.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Nov 10, 2016

Member

Note you do need to run make manifest.

.travis.yml was missing, which I've now fixed. thanks for raising this!

Member

karenetheridge commented Nov 10, 2016

Note you do need to run make manifest.

.travis.yml was missing, which I've now fixed. thanks for raising this!

@pauloscustodio

This comment has been minimized.

Show comment
Hide comment
@pauloscustodio

pauloscustodio Nov 11, 2016

Thanks for explaining.

On Thu, Nov 10, 2016 at 11:56 PM, Karen Etheridge notifications@github.com
wrote:

Closed #33 #33.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAEUdQhlFEV0xwfm-wTtAiYSFSpjUynhks5q868WgaJpZM4KvQx9
.

pauloscustodio commented Nov 11, 2016

Thanks for explaining.

On Thu, Nov 10, 2016 at 11:56 PM, Karen Etheridge notifications@github.com
wrote:

Closed #33 #33.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAEUdQhlFEV0xwfm-wTtAiYSFSpjUynhks5q868WgaJpZM4KvQx9
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment