New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use warnings #25

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@openstrike

openstrike commented Aug 20, 2015

This is a trivial PR to use warnings in the module as recommended by CPANTS. There doesn't appear to be any particular reason not to use warnings for this module and it passes tests cleanly (and quietly) when warnings are used on my test systems.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Aug 21, 2015

Member

I looked at adding the use of warnings a while back, but it would be really risky to introduce new warnings to production systems that are not expecting it -- this can fill up logs quickly.

Member

karenetheridge commented Aug 21, 2015

I looked at adding the use of warnings a while back, but it would be really risky to introduce new warnings to production systems that are not expecting it -- this can fill up logs quickly.

@openstrike

This comment has been minimized.

Show comment
Hide comment
@openstrike

openstrike Aug 21, 2015

The reticence is understandable and I agree with it to a certain extent.

However, as a user I would be inclined towards the use of warnings as by their very nature they should serve to highlight potential problems or unexpected scenarios in either my code or within the module which could then be addressed. If we had an extensive release test (yes, I might be volunteering here) which would cover as many of the combinations of inputs as possible and thereby determine that normal operation were silent even when warnings are used would that be a sufficient enabler for using warnings?

openstrike commented Aug 21, 2015

The reticence is understandable and I agree with it to a certain extent.

However, as a user I would be inclined towards the use of warnings as by their very nature they should serve to highlight potential problems or unexpected scenarios in either my code or within the module which could then be addressed. If we had an extensive release test (yes, I might be volunteering here) which would cover as many of the combinations of inputs as possible and thereby determine that normal operation were silent even when warnings are used would that be a sufficient enabler for using warnings?

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Aug 21, 2015

Member

Yes, potentially :)

On Fri, Aug 21, 2015 at 3:44 AM, Pete Houston notifications@github.com
wrote:

The reticence is understandable and I agree with it to a certain extent.

However, as a user I would be inclined towards the use of warnings as by
their very nature they should serve to highlight potential problems or
unexpected scenarios in either my code or within the module which could
then be addressed. If we had an extensive release test (yes, I might be
volunteering here) which would cover as many of the combinations of inputs
as possible and thereby determine that normal operation were silent even
when warnings are used would that be a sufficient enabler for using
warnings?


Reply to this email directly or view it on GitHub
#25 (comment)
.

Member

karenetheridge commented Aug 21, 2015

Yes, potentially :)

On Fri, Aug 21, 2015 at 3:44 AM, Pete Houston notifications@github.com
wrote:

The reticence is understandable and I agree with it to a certain extent.

However, as a user I would be inclined towards the use of warnings as by
their very nature they should serve to highlight potential problems or
unexpected scenarios in either my code or within the module which could
then be addressed. If we had an extensive release test (yes, I might be
volunteering here) which would cover as many of the combinations of inputs
as possible and thereby determine that normal operation were silent even
when warnings are used would that be a sufficient enabler for using
warnings?


Reply to this email directly or view it on GitHub
#25 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment