Permalink
Browse files

remove 'liblibxmljs' from bindings.gyp

The double lib causes problems for windows (and apprently was a hack
anyway). The compiled bindings can just be called xmljs.
  • Loading branch information...
defunctzombie committed Jan 5, 2013
1 parent dc6c1e3 commit b6b224eb8794151661d31dcf59cdfe43ec8c69f6
Showing with 2 additions and 3 deletions.
  1. +1 −2 binding.gyp
  2. +1 −1 lib/bindings.js
View
@@ -1,8 +1,7 @@
{
'targets': [
{
- # have to specify 'liblib' here since gyp will remove the first one :\
- 'target_name': 'liblibxmljs',
+ 'target_name': 'xmljs',
'sources': [
'src/libxmljs.cc',
'src/xml_attribute.cc',
View
@@ -1 +1 @@
-module.exports = require('bindings')('libxmljs');
+module.exports = require('bindings')('xmljs');

This comment has been minimized.

Show comment Hide comment
@arnski

arnski Feb 21, 2013

Mhm. For some reason installing libxmljs 0.7.0 (npm install libxmljs --save) now leads to

Error: Could not load the bindings file. Tried:
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/Debug/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/Release/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/out/Debug/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/Debug/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/out/Release/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/Release/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/default/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/compiled/0.6.12/linux/x64/xmljs.node
    at bindings (/var/www/nodeapps/wdbs/node_modules/libxmljs/node_modules/bindings/bindings.js:84:13)

...

when using it.

The last step of waf building does indeed produce a "libxmljs.node" instead of just "xmljs.node" (, which i guess was intended):

[10/10] cxx_link: build/Release/src/libxmljs_1.o build/Release/src/xml_attribute_1.o build/Release/src/xml_document_1.o build/Release/src/xml_element_1.o build/Release/src/xml_namespace_1.o build/Release/src/xml_node_1.o build/Release/src/xml_sax_parser_1.o build/Release/src/xml_syntax_error_1.o build/Release/src/xml_xpath_context_1.o -> build/Release/libxmljs.node

Maybe it should state "libxmljs" after all?

P.S.:

vagrant@precise64:/var/www/nodeapps/wdbs$ npm --version
1.1.4
vagrant@precise64:/var/www/nodeapps/wdbs$ node --version
v0.6.12
@arnski

arnski Feb 21, 2013

Mhm. For some reason installing libxmljs 0.7.0 (npm install libxmljs --save) now leads to

Error: Could not load the bindings file. Tried:
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/Debug/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/Release/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/out/Debug/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/Debug/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/out/Release/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/Release/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/build/default/xmljs.node
 → /var/www/nodeapps/wdbs/node_modules/libxmljs/compiled/0.6.12/linux/x64/xmljs.node
    at bindings (/var/www/nodeapps/wdbs/node_modules/libxmljs/node_modules/bindings/bindings.js:84:13)

...

when using it.

The last step of waf building does indeed produce a "libxmljs.node" instead of just "xmljs.node" (, which i guess was intended):

[10/10] cxx_link: build/Release/src/libxmljs_1.o build/Release/src/xml_attribute_1.o build/Release/src/xml_document_1.o build/Release/src/xml_element_1.o build/Release/src/xml_namespace_1.o build/Release/src/xml_node_1.o build/Release/src/xml_sax_parser_1.o build/Release/src/xml_syntax_error_1.o build/Release/src/xml_xpath_context_1.o -> build/Release/libxmljs.node

Maybe it should state "libxmljs" after all?

P.S.:

vagrant@precise64:/var/www/nodeapps/wdbs$ npm --version
1.1.4
vagrant@precise64:/var/www/nodeapps/wdbs$ node --version
v0.6.12

This comment has been minimized.

Show comment Hide comment
@defunctzombie

defunctzombie Feb 21, 2013

Collaborator

The version of node you are using is too old. Please either use the latest 0.6 or really, upgrade to 0.8

@defunctzombie

defunctzombie Feb 21, 2013

Collaborator

The version of node you are using is too old. Please either use the latest 0.6 or really, upgrade to 0.8

0 comments on commit b6b224e

Please sign in to comment.