From e555b9a82d9028dccb1f679aa563106e935c8059 Mon Sep 17 00:00:00 2001 From: Stefan Hundhammer Date: Wed, 7 Nov 2018 14:56:19 +0100 Subject: [PATCH 1/2] Require libQt5Svg5 --- package/libyui-qt-pkg.spec | 5 ++++- src/CMakeLists.txt | 26 +++++++++++++++++++------- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/package/libyui-qt-pkg.spec b/package/libyui-qt-pkg.spec index 91e6568..fbb9c91 100644 --- a/package/libyui-qt-pkg.spec +++ b/package/libyui-qt-pkg.spec @@ -54,6 +54,9 @@ component for libYUI. %package -n %{bin_name} +# bsc#1114654: Need Qt SVG support for icons (built-in and from theme) +Requires: libQt5Svg5 + Requires: libyui%{so_version} Provides: %{name} = %{version} @@ -125,7 +128,7 @@ cmake .. \ -DCMAKE_BUILD_TYPE=RELEASE %endif -make %{?jobs:-j%jobs} +make VERBOSE=1 %{?jobs:-j%jobs} %install cd build diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 2cecf68..358d160 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -1,13 +1,25 @@ # Find includes in corresponding build directories -set(CMAKE_INCLUDE_CURRENT_DIR ON) +set( CMAKE_INCLUDE_CURRENT_DIR ON ) + # Instruct CMake to run moc automatically when needed. -set(CMAKE_AUTOMOC ON) +set( CMAKE_AUTOMOC ON ) + +find_package( Qt5Core CONFIG REQUIRED ) +find_package( Qt5Gui CONFIG REQUIRED ) +find_package( Qt5Widgets CONFIG REQUIRED ) +find_package( Qt5Svg CONFIG REQUIRED ) +find_package( Qt5X11Extras CONFIG REQUIRED ) -set(CMAKE_INCLUDE_PATH ${QT_INCLUDES} ${CMAKE_INCLUDE_PATH}) +set( CMAKE_INCLUDE_PATH ${QT_INCLUDES} ${CMAKE_INCLUDE_PATH} ) PROCESS_SOURCES() -target_link_libraries( - ${TARGETLIB} Qt5::Core Qt5::Gui Qt5::Widgets Qt5::Svg Qt5::X11Extras - ) -SUBDIRS(icons) +target_link_libraries( ${TARGETLIB} + Qt5::Core + Qt5::Gui + Qt5::Widgets + Qt5::Svg + Qt5::X11Extras + ) + +SUBDIRS( icons ) From a20149d1b10ed12518729331b678e6fda9df0779 Mon Sep 17 00:00:00 2001 From: Stefan Hundhammer Date: Wed, 7 Nov 2018 15:02:05 +0100 Subject: [PATCH 2/2] Version bump and change log --- VERSION.cmake | 2 +- package/libyui-qt-pkg-doc.spec | 2 +- package/libyui-qt-pkg.changes | 6 ++++++ package/libyui-qt-pkg.spec | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/VERSION.cmake b/VERSION.cmake index 44b9c3b..5661e73 100644 --- a/VERSION.cmake +++ b/VERSION.cmake @@ -1,6 +1,6 @@ SET( VERSION_MAJOR "2" ) SET( VERSION_MINOR "45" ) -SET( VERSION_PATCH "23" ) +SET( VERSION_PATCH "24" ) SET( VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}" ) ##### This is need for the libyui core, ONLY. diff --git a/package/libyui-qt-pkg-doc.spec b/package/libyui-qt-pkg-doc.spec index dd3b41e..1a35689 100644 --- a/package/libyui-qt-pkg-doc.spec +++ b/package/libyui-qt-pkg-doc.spec @@ -20,7 +20,7 @@ %define so_version 9 Name: %{parent}-doc -Version: 2.45.23 +Version: 2.45.24 Release: 0 Source: %{parent}-%{version}.tar.bz2 diff --git a/package/libyui-qt-pkg.changes b/package/libyui-qt-pkg.changes index 416fcf7..3d8db45 100644 --- a/package/libyui-qt-pkg.changes +++ b/package/libyui-qt-pkg.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Wed Nov 7 14:00:54 UTC 2018 - Stefan Hundhammer + +- Require and link against libQt5Svg (bsc#1114654) +- 2.45.24 + ------------------------------------------------------------------- Tue Nov 6 15:21:12 UTC 2018 - Stefan Hundhammer diff --git a/package/libyui-qt-pkg.spec b/package/libyui-qt-pkg.spec index fbb9c91..b403a35 100644 --- a/package/libyui-qt-pkg.spec +++ b/package/libyui-qt-pkg.spec @@ -17,7 +17,7 @@ Name: libyui-qt-pkg -Version: 2.45.23 +Version: 2.45.24 Release: 0 Source: %{name}-%{version}.tar.bz2