people don't have a "first" and "last" name

https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/

migrates all profile data

Author: ornicar

bin/mongodb/real-name-migrate.js

@@ -0,0 +1,17 @@
+const sel = { $or: [{ 'profile.firstName': { $exists: true } }, { 'profile.lastName': { $exists: true } }] };
+
+db.user4
+  .find(sel, { profile: 1 })
+  .limit(1000)
+  .forEach(function (user) {
+    const fullName = ((user.profile.firstName || '') + ' ' + (user.profile.lastName || ''))
+      .trim()
+      .replace(/\s+/g, ' ');
+    db.user4.updateOne(
+      { _id: user._id },
+      {
+        $set: { 'profile.realName': fullName },
+        $unset: { 'profile.firstName': true, 'profile.lastName': true },
+      },
+    );
+  });

modules/core/src/main/user.scala

@@ -111,8 +111,7 @@ object user:
       @Key("country") flag: Option[String] = None,
       location: Option[String] = None,
       bio: Option[String] = None,
-      firstName: Option[String] = None,
-      lastName: Option[String] = None,
+      realName: Option[String] = None,
       fideRating: Option[Int] = None,
       uscfRating: Option[Int] = None,
       ecfRating: Option[Int] = None,
@@ -121,10 +120,7 @@ object user:
       dsbRating: Option[Int] = None,
       links: Option[String] = None
   ):
-    def nonEmptyRealName =
-      List(ne(firstName), ne(lastName)).flatten match
-        case Nil   => none
-        case names => (names.mkString(" ")).some
+    def nonEmptyRealName = ne(realName)
 
     def nonEmptyLocation = ne(location)
 
@@ -133,9 +129,10 @@ object user:
     def isEmpty = completionPercent == 0
 
     def completionPercent: Int =
-      100 * List(flag, bio, firstName, lastName).count(_.isDefined) / 4
+      100 * List(flag, bio, realName).count(_.isDefined) / 4
 
     private def ne(str: Option[String]) = str.filter(_.nonEmpty)
+
   end Profile
 
   object Profile:

modules/coreI18n/src/main/key.scala

@@ -397,8 +397,7 @@ object I18nKey:
     val `ifNoneLeaveEmpty`: I18nKey = "ifNoneLeaveEmpty"
     val `profile`: I18nKey = "profile"
     val `editProfile`: I18nKey = "editProfile"
-    val `firstName`: I18nKey = "firstName"
-    val `lastName`: I18nKey = "lastName"
+    val `realName`: I18nKey = "realName"
     val `setFlair`: I18nKey = "setFlair"
     val `flair`: I18nKey = "flair"
     val `youCanHideFlair`: I18nKey = "youCanHideFlair"

modules/pref/src/main/ui/AccountPages.scala

@@ -78,8 +78,7 @@ final class AccountPages(helpers: Helpers, ui: AccountUi, flagApi: lila.core.use
             form3.group(form("location"), trans.site.location(), half = true)(form3.input(_))
           ),
           form3.split(
-            form3.group(form("firstName"), trans.site.firstName(), half = true)(form3.input(_)),
-            form3.group(form("lastName"), trans.site.lastName(), half = true)(form3.input(_))
+            form3.group(form("realName"), trans.site.realName(), half = true)(form3.input(_))
           ),
           form3.split(
             List("fide", "uscf", "ecf", "rcf", "cfc", "dsb").map: rn =>

modules/user/src/main/Profile.scala

@@ -23,8 +23,7 @@ object Profile:
 
     def filterTroll(troll: Boolean): Profile = p.copy(
       bio = p.bio.ifFalse(troll),
-      firstName = p.firstName.ifFalse(troll),
-      lastName = p.lastName.ifFalse(troll),
+      realName = p.realName.ifFalse(troll),
       location = p.location.ifFalse(troll),
       links = p.links.ifFalse(troll)
     )

modules/user/src/main/UserForm.scala

@@ -42,8 +42,7 @@ final class UserForm:
       "flag"       -> optional(text.verifying(Flags.codeSet contains _)),
       "location"   -> optional(cleanNoSymbolsAndNonEmptyText(maxLength = 80)),
       "bio"        -> optional(cleanNoSymbolsAndNonEmptyText(maxLength = 400)),
-      "firstName"  -> nameField,
-      "lastName"   -> nameField,
+      "realName"   -> nameField,
       "fideRating" -> optional(number(min = 1400, max = 3000)),
       "uscfRating" -> optional(number(min = 100, max = 3000)),
       "ecfRating"  -> optional(number(min = 0, max = 3000)),

translation/source/site.xml

@@ -509,8 +509,7 @@
   <string name="ifNoneLeaveEmpty">If none, leave empty</string>
   <string name="profile">Profile</string>
   <string name="editProfile">Edit profile</string>
-  <string name="firstName">First name</string>
-  <string name="lastName">Surname</string>
+  <string name="realName">Real name</string>
   <string name="setFlair">Set your flair</string>
   <string name="flair">Flair</string>
   <string name="youCanHideFlair">There is a setting to hide all user flairs across the entire site.</string>