Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board zoom slider does not move smoothly #5184

Closed
isaacl opened this issue Jun 10, 2019 · 4 comments
Closed

board zoom slider does not move smoothly #5184

isaacl opened this issue Jun 10, 2019 · 4 comments
Labels
improvement stale

Comments

@isaacl
Copy link
Member

@isaacl isaacl commented Jun 10, 2019

When I drag the board zoom slider to the right, at certain points the board jerkily gets smaller. some weird rounding artifact? See video

https://www.dropbox.com/s/01p6hozt50mzzgz/boardZoomJitter.mov?raw=1

@ornicar
Copy link
Collaborator

@ornicar ornicar commented Jun 11, 2019

It's because its size must remain a multiple of 8px so that each square has a round size, to avoid SVG artifacts.

@ornicar ornicar closed this as completed Jun 11, 2019
@isaacl
Copy link
Member Author

@isaacl isaacl commented Jun 11, 2019

but the board gets smaller even as I move the mouse uniformly to the right. And then goes back to getting bigger.

I know about the 8px change -- I put that in :-D

@isaacl isaacl reopened this Jun 11, 2019
@niklasf niklasf added the improvement label Jun 23, 2019
@stale
Copy link

@stale stale bot commented Jun 22, 2021

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Jun 22, 2021
@niklasf
Copy link
Member

@niklasf niklasf commented Jun 22, 2021

Looks like it was fixed by lichess-org/chessground@df5cdde and follow ups.

@niklasf niklasf closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement stale
Projects
None yet
Development

No branches or pull requests

3 participants