From 61263bbb670261cf96e75fa348abe77bf331add8 Mon Sep 17 00:00:00 2001 From: Jonathan Gamble Date: Fri, 12 Jul 2024 12:53:45 -0500 Subject: [PATCH] its ok to fetch lobby hacks without preloading --- app/views/base/page.scala | 3 +-- ui/bits/package.json | 1 + ui/bits/src/bits.devMode.ts | 22 ++++++++++++++++++++++ ui/site/package.json | 3 +-- ui/site/src/boot.ts | 1 + ui/site/src/site.devMode.ts | 22 ---------------------- 6 files changed, 26 insertions(+), 26 deletions(-) create mode 100644 ui/bits/src/bits.devMode.ts delete mode 100644 ui/site/src/site.devMode.ts diff --git a/app/views/base/page.scala b/app/views/base/page.scala index 8aca1fa45f02..c0b07307c867 100644 --- a/app/views/base/page.scala +++ b/app/views/base/page.scala @@ -91,8 +91,7 @@ object page: manifests, p.withHrefLangs.map(hrefLangs), sitePreload( - p.modules ++ p.pageModule.so(module => jsPageModule(module.name)) ++ - Option.when(!netConfig.isProd)(Option(jsPageModule("site.devMode"))), + p.modules ++ p.pageModule.so(module => jsPageModule(module.name)), isInquiry = ctx.data.inquiry.isDefined ), lichessFontFaceCss, diff --git a/ui/bits/package.json b/ui/bits/package.json index 4dfd6503ed72..eb451c230115 100644 --- a/ui/bits/package.json +++ b/ui/bits/package.json @@ -55,6 +55,7 @@ "src/bits.contact.ts", "src/bits.cropDialog.ts", "src/bits.dailyFeed.ts", + "src/bits.devMode.ts", "src/bits.diagnosticDialog.ts", "src/bits.eventCountdown.ts", "src/bits.expandText.ts", diff --git a/ui/bits/src/bits.devMode.ts b/ui/bits/src/bits.devMode.ts new file mode 100644 index 000000000000..6083ec6d5dce --- /dev/null +++ b/ui/bits/src/bits.devMode.ts @@ -0,0 +1,22 @@ +import { init as initBoard } from 'common/miniBoard'; + +export function initModule() { + $('main.lobby').each(function (this: HTMLElement) { + // fake tv for debugging layout, ui/build with -d flag + if (this.querySelector('.lobby__tv')) return; + + const ds = document.body.dataset; + const tv = $as( + ` +
+ + CM Tester126490:26 + + FM tester227600:19 + +
`.trim(), + ); + initBoard(tv.querySelector('#fake-tv')!); + this.append(tv); + }); +} diff --git a/ui/site/package.json b/ui/site/package.json index 02a8cb0aa763..a7813d0ae36d 100644 --- a/ui/site/package.json +++ b/ui/site/package.json @@ -19,8 +19,7 @@ "src/site.ts", "src/site.tvEmbed.ts", "src/site.puzzleEmbed.ts", - "src/site.lpvEmbed.ts", - "src/site.devMode.ts" + "src/site.lpvEmbed.ts" ], "sync": { "node_modules/dialog-polyfill/dist/dialog-polyfill.esm.js": "public/npm" diff --git a/ui/site/src/boot.ts b/ui/site/src/boot.ts index b71e5d5c2321..5b4ec763f49d 100644 --- a/ui/site/src/boot.ts +++ b/ui/site/src/boot.ts @@ -124,6 +124,7 @@ export function boot() { if (setBlind && !site.blindMode) setTimeout(() => $('#blind-mode button').trigger('click'), 1500); + if (site.debug) site.asset.loadEsm('bits.devMode'); if (showDebug) site.asset.loadEsm('bits.diagnosticDialog'); const pageAnnounce = document.body.getAttribute('data-announce'); diff --git a/ui/site/src/site.devMode.ts b/ui/site/src/site.devMode.ts deleted file mode 100644 index 1b658fbf3734..000000000000 --- a/ui/site/src/site.devMode.ts +++ /dev/null @@ -1,22 +0,0 @@ -import { init as initBoard } from 'common/miniBoard'; - -requestAnimationFrame(() => { - $('main.lobby').each(function (this: HTMLElement) { - // fake tv for debugging layout, ui/build with -d flag - if (site.debug && !this.querySelector('.lobby__tv')) { - const ds = document.body.dataset; - const tv = $as( - ` -
- - CM Tester126490:26 - - FM tester227600:19 - -
`.trim(), - ); - initBoard(tv.querySelector('#fake-tv')!); - this.append(tv); - } - }); -});