NVUI Round Additions #7772

TTWNO · 2020-12-23T23:09:00Z

Change board in NVUI interface to be navigable on its own.

It does not implement all features of the text input box interface, yet. But I'm working on that. If I could have anyone using a screen reader, or anyone on the accessibility threads test these changes, that would be fantastic.

A live version of this branch is available on https://chess.tait.tech/

Also looking at analysis board and the ability to get information about pieces which can attack/protect certain squares. A sighted player will see their rook is being attacked on the long diagonal, but a novice visually impaired player who does not play in their head will likely not see that. Looking into server-side changes to allow this information to be sent to the client.

Thanks for the great site!

I will ping a few issues and users who seem to care about this.

#7084 #6401

@kraktus @montalvonet

…ning or end of piece lists

…sounds from Emacspeak

…some piece styles

ornicar

Interesting. I'd like visually impaired players to weight on this.
Writing new features is fun, but maintaining them for years and years to come is not. And I'll very probably be the one doing it. So for every feature I must be very sure that they're worth the cost, and that enough people use them.
I developed the current NVUI in collaboration with visually impaired players, and they never mentioned something like this.

Where do the sounds come from?

ornicar · 2020-12-24T16:48:08Z

.vscode/settings.json

@@ -0,0 +1,5 @@
+{


please ignore these filenames with global gitiginore in ~/.gitconfig

ornicar · 2020-12-24T16:50:55Z

ui/build

@@ -56,7 +56,7 @@ if [ $mode == "css" ]; then
 else
  if type -p parallel; then # parallel execution!
    if [ -z "$P_OPTS" -a ! -e ~/.parallel/config ]; then
-      P_OPTS="-j+4 --halt 2"
+      P_OPTS="-j+12 --halt 2"


no, please don't commit that

ornicar · 2020-12-24T16:52:43Z

ui/round/src/sound.ts

@@ -6,3 +6,7 @@ export const move = throttled('move');
 export const capture = throttled('capture');
 export const check = throttled('check');
 export const explode = throttled('explosion');
+export const select = throttled('select');


keep these in the nvui files to avoid tainting the main gameplay code

TTWNO · 2020-12-24T17:05:28Z

The sounds come from a GPLv2 project: Emacspeak. An Emacs extention for speech output.

I added this for the casual low-vision user. Someone who is not good at chess, or even doesn't know the rules very well. I have heard from a few of my friends with screenreaders that being able to navigate around a board is more intuitive when learning something new. That's also why I left the already implemented nvui the way it is.

Sorry about committing those settings files and compile options. Should be fixed right away.

…e squares in the visual version)

ornicar · 2020-12-28T13:13:50Z

Hmm I'm getting compilation errors:

cd ui/round
yarn plugin-dev nvui

yarn run v1.22.10
$ rollup --config --config-plugin nvui

src/plugins/nvui.ts → ../../public/compiled/round.nvui.js...
(!) Plugin typescript: @rollup/plugin-typescript TS6133: 'lastCaptured' is declared but its value is never read.
src/plugins/nvui.ts: (15:122)

15 import { renderSan, renderPieces, renderBoard, styleSetting, pieceSetting, prefixSetting, positionSetting, boardSetting, lastCaptured, PieceStyle, PrefixStyle } from 'nvui/chess';
                                                                                                                            ~~~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS6133: 'PieceStyle' is declared but its value is never read.
src/plugins/nvui.ts: (15:136)

15 import { renderSan, renderPieces, renderBoard, styleSetting, pieceSetting, prefixSetting, positionSetting, boardSetting, lastCaptured, PieceStyle, PrefixStyle } from 'nvui/chess';
                                                                                                                                          ~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS6133: 'PrefixStyle' is declared but its value is never read.
src/plugins/nvui.ts: (15:148)

15 import { renderSan, renderPieces, renderBoard, styleSetting, pieceSetting, prefixSetting, positionSetting, boardSetting, lastCaptured, PieceStyle, PrefixStyle } from 'nvui/chess';
                                                                                                                                                      ~~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS6133: 'symbolToFile' is declared but its value is never read.
src/plugins/nvui.ts: (19:53)

19 import { castlingFlavours, supportedVariant, Style, symbolToFile, roundBoardListenersSetup } from 'nvui/chess';
                                                       ~~~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS2305: Module '"../../../../node_modules/nvui/chess"' has no exported member 'roundBoardListenersSetup'.
src/plugins/nvui.ts: (19:67)

19 import { castlingFlavours, supportedVariant, Style, symbolToFile, roundBoardListenersSetup } from 'nvui/chess';
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS6133: 'roundBoardListenersSetup' is declared but its value is never read.
src/plugins/nvui.ts: (19:67)

19 import { castlingFlavours, supportedVariant, Style, symbolToFile, roundBoardListenersSetup } from 'nvui/chess';
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS6133: 'TourStandingCtrl' is declared but its value is never read.
src/plugins/nvui.ts: (21:1)

21 import { TourStandingCtrl } from '../tourStanding';
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS2345: Argument of type 'Setting<PieceStyle>' is not assignable to parameter of type 'PieceStyle'.
  Type 'Setting<PieceStyle>' is not assignable to type '"white uppercase name"'.
src/plugins/nvui.ts: (132:107)

132             $board.on('keypress', lastCapturedCommandHandler(() => ctrl.data.steps.map(step => step.fen), pieceStyle, prefixStyle));
                                                                                                              ~~~~~~~~~~

(!) Plugin typescript: @rollup/plugin-typescript TS2322: Type 'string | { [key: string]: string; } | undefined' is not assignable to type 'string | { [key: string]: string; }'.
  Type 'undefined' is not assignable to type 'string | { [key: string]: string; }'.
src/plugins/nvui.ts: (136:64)

136             $buttons.on('keypress', possibleMovesHandler(() => ctrl.data.possibleMoves, () => ctrl.chessground.state.pieces));
                                                                   ~~~~~~~~~~~~~~~~~~~~~~~

  ../nvui/chess.d.ts:32:61
    32 export declare function possibleMovesHandler(possibleMoves: () => string | {
                                                                   ~~~~~~~~~~~~~~~~
    33     [key: string]: string;
       ~~~~~~~~~~~~~~~~~~~~~~~~~~
    34 }, pieces: () => Pieces): (ev: KeyboardEvent) => boolean;
       ~
    The expected type comes from the return type of this signature.

Also I see changes in ui/analyse, but I thought this PR was about gameplay only? It should be.

Finally, the opponent legal moves aren't sent to save (a lot of) bandwidth. That won't change. If you need them, you could add a dependency to chessops to generate them on client side.

TTWNO · 2020-12-28T18:32:10Z

Also I see changes in ui/analyse, but I thought this PR was about gameplay only? It should be.

The event listeners on the rendered nvui board for analysis are different from the ones for playing an actual game. You pointed out that the analysis board was broken; I fixed it by not initializing an event listener which is compatible with RoundData only, and not AnalyseData.

Hopefully that makes sense.

Working on compile errors now.

…ns. Currently auto-queen.

… your turn.

TTWNO · 2020-12-30T01:06:30Z

The selectionHandler and pieceJumpingHandler depend on functionality from the other to properly handle choosing a piece for promotion.
A promotion="true" attribute is added to the destination button, then an aria-live notification tells the user to use q/n/b/r to select their promotion piece. Once a valid key is pressed, it removes the promotion attribute from the button, restoring normal piece jumping functionality to the square.

EDIT: Any suggestions on how to make this better? I feel like coupling two handlers like that isn't the right way.

ornicar · 2021-01-13T18:58:36Z

If I merge this, do you plan on maintaining it?

TTWNO · 2021-01-14T03:33:41Z

Yes, sir!

ornicar · 2021-01-14T10:40:02Z

ui/round/src/plugins/nvui.ts

+      console.log(uci);
+      console.log(uci.slice(0, -1));
+      console.log(promotion);
+      console.log(legalSans);


this debug should probably be removed now

ornicar · 2021-01-14T10:43:02Z

alright then, here goes nothin!

ornicar · 2021-01-14T10:51:43Z

Feel free to join our dev discord server: https://discord.gg/pw6Efvk

Could be useful to discuss follow-up on this feature.

ornicar · 2021-01-14T10:53:45Z

the changes are online

montalvonet · 2021-01-15T13:54:18Z

Awesome!, i tried this morning the site and what a wonderful work!. Where do i find the list of all changes to notify our big blind group? 2021-01-14 4:54 GMT-06:00, Thibault Duplessis <notifications@github.com>:

…

the changes are online -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #7772 (comment)

TTWNO · 2021-01-15T14:13:24Z

@montalvonet

Make the board navigable by specialized keyboard commands. Make sure to disable browse mode to use this. The keys must be passed through to the browser directly. Go under the level 2 header "board" to use these features.
There are 4 settings as to how the board should be rendered, check them out under the "board settings" level 3 header.
Finally, under the level 2 header "board commands" there is a list of all the keys that may be used with the new additions.

Even though pawn promotion is not mentioned in the list of commands, it does work. However, it overrides the "piece jumping" functionality for the destination.

To give an example: normally n/b/r/q/k will take you to the next knight/bishop/rook/queen/king, but when you move a pawn from let's say a7 to a8, now a8 will not jump around with those letters, but rather those letters become the piece you want to promote to. You may still use piece jumping by going left or right from the pawn promotion destination tile and continue browsing the board. But that destination square, a8, is whwre your focus must be if you want to promote your pawn.

Hope that makes sense.

montalvonet · 2021-01-15T22:16:28Z

Hi Tait, I have tried already the new board, the only thing is when we want to enter a move under the board, is confuse, the way we use in the world is: nf4 or a6 or re1, but this does not work under the new board. Enviado desde Correo para Windows 10 De: Tait HoyemEnviado: viernes, 15 de enero de 2021 08:13 a. m.Para: ornicar/lilaCC: montalvonet; MentionAsunto: Re: [ornicar/lila] NVUI Round Additions (#7772) @montalvonetMake the board navigable by specialized keyboard commands. Make sure to disable browse mode to use this. The keys must be passed through to the browser directly. Go under the level 2 header "board" to use these features.There are 4 settings as to how the board should be rendered, check them out under the "board settings" level 3 header.Finally, under the level 2 header "board commands" there is a list of all the keys that may be used with the new additions.Even though pawn promotion is not mentioned in the list of commands, it does work. However, it overrides the "piece jumping" functionality for the destination.To give an example: normally n/b/r/q/k will take you to the next knight/bishop/rook/queen/king, but when you move a pawn from let's say a7 to a8, now a8 will not jump around with those letters, but rather those letters become the piece you want to promote to. You may still use piece jumping by going left or right from the pawn promotion destination tile and continue browsing the board. But that destination square, a8, is whwre your cursor must be if you want to promote your pawn.Hope that makes sense.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

TTWNO · 2021-01-15T22:31:23Z

@montalvonet That is correct. To submit a move using standard notation, you must move back to the "your move" input box and submit your move there.

If you would like a key which can move you to the input box automatically, please make an issue for it with descriptions about which key should bring you to the input box, and which key should bring you back. The more detail I have from you, the easier it is for me to make a patch.

Please make a new issue if you wish to discuss this further.

montalvonet · 2021-01-16T06:10:40Z

Well I think there are only a few details: Something like “Ctrl+EscEnviado desde Correo para Windows 10 De: Tait HoyemEnviado: viernes, 15 de enero de 2021 04:31 p. m.Para: ornicar/lilaCC: montalvonet; MentionAsunto: Re: [ornicar/lila] NVUI Round Additions (#7772) @montalvonet That is correct. To submit a move using standard notation, you must move back to the "your move" input box and submit your move there.If you would like a key which can move you to the input box automatically, please make an issue for it with descriptions about which key should bring you to the input box, and which key should bring you back. The more detail I have from you, the easier it is for me to make a patch.Please make a new issue if you wish to discuss this further.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Tait Hoyem added 24 commits December 14, 2020 21:59

Broken patch to enable tabulated nvui board

691c0bf

Working POC of accessible chessboard w/ table

8ad906d

Add 'select' sound for new NVUI table; sourced from Emacspeak/GPLv2

a4c9f00

Udpate name of sound files

3b87500

Add 'select' sound to NVUI games

17f455d

Cleanup code, put functions in the right files

887ecce

More code cleanup

27d3bce

update comment

b19be13

Update prefix, add to analyse board

368dea8

Add arrow navigation in table

80d7e18

Add option to show position on the button

61aff0f

Remove table, use div/span

f6da6cf

Remove literate verbose

89258ab

Add piece navigation with kK/qQ/rR/bB/nN/pP

251a42c

Add error sound to trying to navigate off the table, or and the begin…

a8d7640

…ning or end of piece lists

Wrap around when searching by piece; update sounds with more GPLv2'd …

e2767a0

…sounds from Emacspeak

Cleanup, start board key handlers

9cef38a

Add position jumping, add current pos and last move status

033fea6

Add 'last taken' command

55c6f5f

Simplify arrowkey handler

a20f19e

Code cleanup, add get captured piece type

44aac6e

Ready for testing; fix last captured piece bug

31885f1

Add debugging for weird issue where piece jumping odesn't work

29b21a7

Remove debugging info; fix bug where piece jumping did not work with …

7193673

…some piece styles

TTWNO changed the title ~~Nvui table board~~ NVUI Round Additions Dec 23, 2020

ornicar reviewed Dec 24, 2020

View reviewed changes

Tait Hoyem added 3 commits December 24, 2020 10:22

Add .vscode to .gitignore

ea70e23

Revert changes... I see what was meant now

70fe794

Revert build to use j+4

b2101d5

Tait Hoyem added 3 commits December 27, 2020 20:31

Remove 'possibleOppositeMoves' field

7137ce0

Remove odests from ApiMove

ba7c9b6

Cleanup and announce possible moves (just like the highlighting of th…

ada4368

…e squares in the visual version)

Tait Hoyem added 12 commits December 28, 2020 12:03

Fix compile errors.

d855399

Cleanup possibleMoveHandler

dff7792

Update board commands documentation

c31d5c4

Remove extra <br>

f6fd53f

Update comment

cbc1f9a

Cleanup possibleMovesHandler more

2d3a289

Add UCI promotion notation; preparing for adding options for promotio…

59814b2

…ns. Currently auto-queen.

Add pawn promotion handler. Couples two listeners together though.

b04724e

Fix 'invalid' error message.

3853214

ctrl.data.possibleMoves -> ctrl.chessground.state.movable

582daa3

Allow checking of possible moves for your pieces, even when it is not…

3587849

… your turn.

Revrert some changes to files that should not have been touched.

17f9adc

ornicar reviewed Jan 14, 2021

View reviewed changes

ornicar merged commit 51d8f38 into lichess-org:master Jan 14, 2021

Uh oh!

NVUI Round Additions #7772

NVUI Round Additions #7772

Uh oh!

Conversation

TTWNO commented Dec 23, 2020

Uh oh!

ornicar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ornicar Dec 24, 2020

Choose a reason for hiding this comment

Uh oh!

ornicar Dec 24, 2020

Choose a reason for hiding this comment

Uh oh!

ornicar Dec 24, 2020

Choose a reason for hiding this comment

Uh oh!

TTWNO commented Dec 24, 2020

Uh oh!

ornicar commented Dec 28, 2020

Uh oh!

TTWNO commented Dec 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TTWNO commented Dec 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ornicar commented Jan 13, 2021

Uh oh!

TTWNO commented Jan 14, 2021

Uh oh!

ornicar Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

ornicar commented Jan 14, 2021

Uh oh!

ornicar commented Jan 14, 2021

Uh oh!

ornicar commented Jan 14, 2021

Uh oh!

montalvonet commented Jan 15, 2021 via email

Uh oh!

TTWNO commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

montalvonet commented Jan 15, 2021 via email

Uh oh!

TTWNO commented Jan 15, 2021

Uh oh!

montalvonet commented Jan 16, 2021 via email

Uh oh!

Uh oh!

ornicar left a comment •

edited

Loading

TTWNO commented Dec 28, 2020 •

edited

Loading

TTWNO commented Dec 30, 2020 •

edited

Loading

TTWNO commented Jan 15, 2021 •

edited

Loading