David Li lidavidm

Organizations

@sympy
@lidavidm
@lidavidm
lidavidm commented on pull request sympy/sympy#9689
@lidavidm

Alright, so the issue is in _nonlinear_3eq_order1_type1 in solvers/ode.py. The original TypeError caused by indexing the None causes it to try a di…

lidavidm commented on pull request sympy/sympy#9689
@lidavidm

Hmm, not sure about that test failure. It looks like one of the solvers does something different when it encounters a TypeError?

lidavidm commented on pull request nskicpp/exercises#11
@lidavidm

Pushed some fixes, will merge into original commits using rebase later.

@lidavidm
@lidavidm

print won't help, but it could be valid.

@lidavidm

Yeah, it wouldn't really change the behavior, since if the digit was invalid, the result would be worthless anyways. And maintainability would be s…

lidavidm opened pull request sympy/sympy#9689
@lidavidm
Don't assume that match result is not None in manualintegrate
1 commit with 6 additions and 0 deletions
lidavidm created branch issue_9687 at lidavidm/sympy
lidavidm commented on issue sympy/sympy#9687
@lidavidm

It's assuming that subexpr.match(query) is not None for each subexpr in expr.find(query). I guess it should check if the match is None, and if so, …

lidavidm opened pull request nskicpp/exercises#11
@lidavidm
David exercise4 (attempt 2)
6 commits with 336 additions and 2 deletions
@lidavidm
lidavidm closed pull request nskicpp/exercises#9
@lidavidm
David exercise 4
lidavidm commented on pull request nskicpp/exercises#9
@lidavidm

Okay, thanks for the feedback! I think I'm just going to nuke this branch + commits and redo the commits after I've fixed up everything.

@lidavidm

Gah, this is sort of a bad habit from Go (if you're initializing it to a zero value you're encouraged to declare it as var input []byte instead of i…

@lidavidm
  • @lidavidm 227a8fb
    Improve prime divisors algorithm
@lidavidm
  • @lidavidm 5776f2a
    Remove -fsized-deallocation as Clang 3.6.x does not implement it
lidavidm opened pull request nskicpp/exercises#9
@lidavidm
David exercise 4
4 commits with 317 additions and 2 deletions
@lidavidm
  • @lidavidm 0308c84
    Implement stack language and prime factor exercise
@lidavidm

Let's do it.

@lidavidm

Yeah, I overquoted, but I guess I'd like to make it explicit here.

lidavidm opened pull request nskicpp/exercises#7
@lidavidm
Fix lesson 3 tests so that pipes are actually processed by shell
1 commit with 4 additions and 4 deletions
lidavidm closed pull request nskicpp/exercises#3
@lidavidm
David's exercise 3
lidavidm commented on pull request nskicpp/exercises#3
@lidavidm

Please see #5

lidavidm opened pull request nskicpp/exercises#5
@lidavidm
David exercise3 (#2, cleaned up commits)
2 commits with 33 additions and 0 deletions