Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the MachO LC_RPATH command #128

Merged
merged 2 commits into from Dec 17, 2017
Merged

Conversation

0xbf00
Copy link
Contributor

@0xbf00 0xbf00 commented Dec 14, 2017

This patch adds parsing for the LC_RPATH command. The LC_RPATH command is used to specify an additional root path where libraries can be found. Multiple LC_RPATH commands can be included in a single MachO file.

Unfortunately, none of the test binaries feature such a command. Therefore, I have not yet added a test, though I did test the functionality on my own.

@romainthomas
Copy link
Member

Very nice! I'll add tests as well as a binary having this command before merging

@0xbf00
Copy link
Contributor Author

0xbf00 commented Dec 15, 2017

I'd gladly take this off your plate. I have a small test binary (~12 K) already and can write a test later today. How does this sound to you?

@0xbf00
Copy link
Contributor Author

0xbf00 commented Dec 17, 2017

I've now added a small test case. Automated tests will likely fail right now, because my sample has not been merged into the samples repository.

@romainthomas
Copy link
Member

I merged the test case and restarted the CI

@romainthomas romainthomas merged commit 09f4a40 into lief-project:master Dec 17, 2017
@romainthomas
Copy link
Member

Thanks for the PR

romainthomas added a commit that referenced this pull request Jan 17, 2022
Parse the MachO LC_RPATH command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants