Parse the MachO LC_RPATH command #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! I'll add tests as well as a binary having this command before merging |
|
I'd gladly take this off your plate. I have a small test binary (~12 K) already and can write a test later today. How does this sound to you? |
|
I've now added a small test case. Automated tests will likely fail right now, because my sample has not been merged into the samples repository. |
|
I merged the test case and restarted the CI |
|
Thanks for the PR |
romainthomas
added a commit
that referenced
this pull request
Jan 17, 2022
Parse the MachO LC_RPATH command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This patch adds parsing for the LC_RPATH command. The LC_RPATH command is used to specify an additional root path where libraries can be found. Multiple LC_RPATH commands can be included in a single MachO file.
Unfortunately, none of the test binaries feature such a command. Therefore, I have not yet added a test, though I did test the functionality on my own.