-
-
Notifications
You must be signed in to change notification settings - Fork 646
Endian support for ELF parsing #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation read byte-by-byte which lead to incorrect values for BigEndian binaries.
Native-endian arrays were not properly initialized.
Should be ok now. My sample ELFs, both BE and LE, are being parsed fine. |
Hum, CI still fail. |
Fixed an inverted test condition when parsing Gnu Hash ELF notes.
I figured out how to get the unit tests running on my machine and observed two problems:
|
Looks good :) I'll do a deep review next week, Thanks! |
I almost finished the review. It will be merged by the end of the day. |
Sweet, thanks! |
Merged with e794ac1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests allows lief to parse ELF binaries with a foreign-endian encoding. It also adds a little fix to how Note sections in ELFs are parsed (read in as 4 byte words) so that foreign-endian instances retain the expected values.