Set overlay to empty vector if no overlay exists #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainthomas
added a commit
that referenced
this pull request
Jul 18, 2017
Set overlay to empty vector if no overlay exists
romainthomas
added a commit
that referenced
this pull request
Jan 17, 2022
Set overlay to empty vector if no overlay exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As part of pull request #34 I missed a commit that updated PE/Parser.cpp that set the overlay to an empty vector if the overlay doesn't exist. This pull request includes this missed commit.