Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pe crash #47

Closed
wants to merge 2 commits into from
Closed

Pe crash #47

wants to merge 2 commits into from

Conversation

alvarofe
Copy link
Contributor

@alvarofe alvarofe commented Jul 7, 2017

I found this crash (NULL dereference) while fuzzing LIEF. I attach a possible fix and the sample.

@romainthomas
Copy link
Member

romainthomas commented Jul 7, 2017 •
edited

Hi @alvarofe, thank you for the bug report. I suggest this fix: d0b7484 because the check is done at the creation of the ResourcesManager object and not in its methods.

@romainthomas romainthomas self-assigned this Jul 7, 2017
@romainthomas
Copy link
Member

romainthomas commented Jul 7, 2017 •
edited

Merged with 7006c90: 4c71e6b + cabc4ba

@alvarofe
Copy link
Contributor Author

alvarofe commented Jul 8, 2017 •
edited

It makes more sense in the creation of the class

@romainthomas romainthomas mentioned this pull request Jul 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@romainthomas romainthomas

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alvarofe @romainthomas