Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-118557 #1767

Closed
wants to merge 69 commits into from
Closed

LPS-118557 #1767

wants to merge 69 commits into from

Conversation

jgarcialr
Copy link

No description provided.

carolmoreschi and others added 30 commits August 4, 2020 19:01
@carolmoreschi @brianchandotcom
LRQA-60257 dxp MP version
056b032
@joshchong @brianchandotcom
LRQA-60690 Add to environment and acceptance suites
b1042d6
@ruben-pulido @brianchandotcom
LPS-118338 Overload InfoItemFormProvider with getInfoForm(String form…
a1d7cb8 
…VariationKey, long groupId) with default implementation
@ruben-pulido @brianchandotcom
LPS-118338 Implement getInfoForm(String formVariationKey, long groupI…
0ec1b05 
…d) in JournalArticleInfoItemFormProvider
@ruben-pulido @brianchandotcom
LPS-118338 Implement getInfoForm(String formVariationKey, long groupI…
7a3b37e 
…d) in BlogsEntryInfoItemFormProvider
@ruben-pulido @brianchandotcom
LPS-118338 Pass scopeGroupId when getting InfoForm from MappingConten…
3fac17e 
…tUtil
@shuyangzhou @brianchandotcom
LPS-115016 Move FileInstaller tracking to DirectoryWatcher
1d8a7ee
@shuyangzhou @brianchandotcom
LPS-115016 Inline
9a6a363
@shuyangzhou @brianchandotcom
LPS-115016 Setting watch dirs is mandatory for liferay.
d9c54ed
@shuyangzhou @brianchandotcom
LPS-115016 Hash out the possible duplicated dirs prior creation to av…
1f780bf 
…oid the weird "pid".
@shuyangzhou @brianchandotcom
LPS-115016 Make _directoryWatchers effientively read-only during runt…
50eaae8 
…ime, so that the synchronized protection is not needed anymore.
@shuyangzhou @brianchandotcom
LPS-115016 Not needed anymore
bd97345
@shuyangzhou @brianchandotcom
LPS-115016 Simplify
9ff696d
@shuyangzhou @brianchandotcom
LPS-115016 We don't do any substituion for file install's own configu…
405c783 
…ration info.
@shuyangzhou @brianchandotcom
LPS-115016 Inline
e631d3c
@shuyangzhou @brianchandotcom
LPS-115016 Inline
f671eaa
@shuyangzhou @brianchandotcom
LPS-115016 Inline
ff478d6
@shuyangzhou @brianchandotcom
LPS-115016 Not used anywhere.
0f820c7
@shuyangzhou @brianchandotcom
LPS-115016 There is no more substitution or field holding, there is n…
cc522cc 
…o need to copy the map anymore.
@shuyangzhou @brianchandotcom
LPS-115016 Use GetterUtil
5ed2e0c
@mtambara @brianchandotcom
LPS-118307 Remove environment variable substitution
0138b8b
@mtambara @brianchandotcom
LPS-118307 Remove bundleContext substitution
db6b423
@mtambara @brianchandotcom
LPS-118307 TypedProperties uses the same substitution logic every time
775d158
@mtambara @brianchandotcom
LPS-118307 Remove BundleContextSubstitutionCallback
6455244
@mtambara @brianchandotcom
LPS-118307 Remove expansion modifiers
156f713
@mtambara @brianchandotcom
LPS-118307 Don't need extra argument, just pass in null
e9bb5af
@mtambara @brianchandotcom
LPS-118307 Add test for storing system property substitutions
ca1037a
@mtambara @brianchandotcom
LPS-118307 Remove in-file substitutions
fbd7b9f
@mtambara @brianchandotcom
LPS-118307 Don't need any SubstitutionalCallbacks anymore
85a814e
@mtambara @brianchandotcom
LPS-118307 Remove unused
a59f5ee
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jgarcialr
Copy link
Author

ci:test:sf

@jgarcialr
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 88a3387a4f2fece3a36d6de94d2191ae3a1237ea

Sender Branch:

Branch Name: LPS-118557
Branch GIT ID: bafb38e521930637188c5231009ee61ae0a6650d

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4174
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#1767
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - jgarcialr > liferay-echo - PR#1767 - 2020-08-05[00:51:00]
Spira Jenkins Build:publish-spira-report#2203

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 78 out of 78 jobs passed in 1 hour 49 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9b5ee1b6d26d88144f66ffc69789f81671914d14

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: a4eb9471e502819c1cfc9d16ef0eea0078d40a10

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 78 out of 78 jobs PASSED
78 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#8013
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#1767
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - jgarcialr > liferay-echo - PR#1767 - 2020-08-05[01:09:18]
Spira Jenkins Build:publish-spira-report#2204

@jkappler
Copy link

jkappler commented Aug 5, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Aug 5, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#92320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone