Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-117494 #1858

Closed
wants to merge 2 commits into from
Closed

[TS] LPS-117494 #1858

wants to merge 2 commits into from

Conversation

ChrisKian
Copy link

LPS-117494

Previous Pull Request
ChrisKian#244

From @jesseyeh-liferay:

Changelog

  • Use indexer post-processor approach to unescape content as suggested in PTR-1842
  • Allow   to be unescaped

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ChrisKian
Copy link
Author

ci:test:sf

@ChrisKian
Copy link
Author

ci:test:relevant

@ChrisKian ChrisKian mentioned this pull request Aug 12, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 750dea180b1c913c0a3f2c3fd11d7cb9c6224d1b

Sender Branch:

Branch Name: pr-249
Branch GIT ID: c8bd6e645c06a27369ca14fab7dafd3b466f959a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#3170
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#1858
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - ChrisKian > liferay-echo - PR#1858 - 2020-08-12[10:01:12]
Spira Jenkins Build:publish-spira-report#2413

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 61 out of 61 jobs passed in 1 hour 59 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 38b09127ba6c6277c9377c1d0bb78fbc07c90ae7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: a4eb9471e502819c1cfc9d16ef0eea0078d40a10

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 61 out of 61 jobs PASSED
61 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#6335
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#1858
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - ChrisKian > liferay-echo - PR#1858 - 2020-08-12[10:00:05]
Spira Jenkins Build:publish-spira-report#2711

@jkappler
Copy link

Just started reviewing :)

@jkappler
Copy link

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#92679

@lipusz
Copy link

lipusz commented Jul 16, 2021 •
edited

Hey Guys, @ChrisKian @jesseyeh-liferay @jkappler

One question: wouldn't it have been simpler to modify the doGetSummary method of JournalArticleIndexer? 🤔

@jkappler
Copy link

Hi @lipusz, please feel free to send us a pull request with your approach. We are always happy to improve/simplify what we have.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
5 participants
@ChrisKian @liferay-continuous-integration @jkappler @lipusz @jesseyeh-liferay