LPS-127800 Removes unnecessary call since we are doing it in the previous line #3811

ealonso · 2021-02-22T19:58:07Z

forward

and the duplicated code here would result parent site admin without MANAGE_SUBGROUPS be able to manage sub groups because AdvancePermissionChecker.isGroupAdminImpl() return true for pretty much any permission for an site admin

…ious line

ealonso · 2021-02-22T19:58:08Z

ci:forward

Sent from GH.

liferay-continuous-integration · 2021-02-22T19:58:10Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

liferay-continuous-integration · 2021-02-22T19:58:13Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-02-22T20:03:13Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 391515151cbd217d911d7d91daf25245294d7e72

Sender Branch:

Branch Name: LPS-127800
Branch GIT ID: 7ac3c1de6fcaddb95cad2cdcfbe72fddd78f96d3

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-02-22T21:48:53Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 49 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 391515151cbd217d911d7d91daf25245294d7e72

Upstream Comparison:

Branch GIT ID: 9ee6723c4a86ae1bbe5da6147d44af259dd9ba58
Jenkins Build URL: Acceptance Upstream DXP (master) #1569

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 23 jobs PASSED

3 Failed Jobs:

20 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 9ee6723:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
54 Tests Passed.
8 Tests Failed.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

1805 Tests Passed.
5 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #464430

BlogPostingResourceTest.testGetBlogPostingRenderedContentByDisplayPageDisplayPageKey

java.lang.AssertionError: Thread Thread[http-nio-8080-exec-6,5,main] caught concurrent failure: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper, message=java.lang.RuntimeException: Unable to get class name from id 0
java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper, message=java.lang.RuntimeException: Unable to get class name from id 0
	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:60)
	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
	at org.apache.log4j.Category.callAppenders(Category.java:206)
	at org.apache.log4j.Category.forcedLog(Category.java:391)
	at org.apache.log4j.Category.log(Category.java:856)
	at com.liferay.portal.log.Log4jLogImpl.error(Log4jLogImpl.java:54)
	at com.liferay.portal.kernel.log.LogWrapper.error(LogWrapper.java:69)
	at com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper.getProblem(ExceptionMapper.java:31)
	at com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper.getProblem(ExceptionMapper.java:27)
	at com.liferay.portal.vulcan.jaxrs.exception.mapper.BaseExceptionMapper.toResponse(BaseExceptionMapper.java:36)
	at org.apache.cxf.jaxrs.utils.ExceptionUtils.convertFaultToResponse(ExceptionUti...

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
java.lang.RuntimeException: Unable to get class name from id 0
java.lang.RuntimeException: Unable to get class name from id 0
	at com.liferay.portal.util.PortalImpl.getClassName(PortalImpl.java:1637)
	at com.liferay.analytics.reports.web.internal.info.display.contributor.util.LayoutDisplayPageProviderUtil.initLayoutDisplayPageObjectProvider(LayoutDisplayPageProviderUtil.java:48)
	at com.liferay.analytics.reports.web.internal.request.attributes.contributor.AnalyticsReportsInfoDisplayRequestAttributesContributor.addAttributes(AnalyticsReportsInfoDisplayRequestAttributesContributor.java:42)
	at com.liferay.layout.type.controller.display.page.internal.layout.type.controller.DisplayPageLayoutTypeController.addAttributes(DisplayPageLayoutTypeController.java:267)
	at com.liferay.layout.type.controller.display.page.internal.layout.type.controller.DisplayPageLayoutTypeController.includeLayoutContent(DisplayPageLayoutTypeController.java:196)
	at com.liferay.portal.model.impl.LayoutImpl.includeLayoutContent(LayoutImpl.java:910)
	at com.liferay.headless.delivery.internal.dto.v1_0.util.DisplayPageRendererUtil.toHTML(DisplayPageRendererUtil.java:183)
	at com.liferay.headless.delivery.internal.resource.v1_0.BlogPostingResourceImpl.getBlogPostingRenderedContentByDisplayPageDisplayPageKey(BlogPostingResourceImpl.java:115)
	at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:179)
	at org.apache.cxf.service.invoker.A...

DocumentResourceTest.testGetDocumentRenderedContentByDisplayPageDisplayPageKey

java.lang.AssertionError: Thread Thread[http-nio-8080-exec-5,5,main] caught concurrent failure: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper, message=java.lang.RuntimeException: Unable to get class name from id 0
java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper, message=java.lang.RuntimeException: Unable to get class name from id 0
	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:60)
	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
	at org.apache.log4j.Category.callAppenders(Category.java:206)
	at org.apache.log4j.Category.forcedLog(Category.java:391)
	at org.apache.log4j.Category.log(Category.java:856)
	at com.liferay.portal.log.Log4jLogImpl.error(Log4jLogImpl.java:54)
	at com.liferay.portal.kernel.log.LogWrapper.error(LogWrapper.java:69)
	at com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper.getProblem(ExceptionMapper.java:31)
	at com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper.getProblem(ExceptionMapper.java:27)
	at com.liferay.portal.vulcan.jaxrs.exception.mapper.BaseExceptionMapper.toResponse(BaseExceptionMapper.java:36)
	at org.apache.cxf.jaxrs.utils.ExceptionUtils.convertFaultToResponse(ExceptionUti...

AXIS_VARIABLE=1,label_exp=!master #464430

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
java.lang.RuntimeException: Unable to get class name from id 0
java.lang.RuntimeException: Unable to get class name from id 0
	at com.liferay.portal.util.PortalImpl.getClassName(PortalImpl.java:1637)
	at com.liferay.analytics.reports.web.internal.info.display.contributor.util.LayoutDisplayPageProviderUtil.initLayoutDisplayPageObjectProvider(LayoutDisplayPageProviderUtil.java:48)
	at com.liferay.analytics.reports.web.internal.request.attributes.contributor.AnalyticsReportsInfoDisplayRequestAttributesContributor.addAttributes(AnalyticsReportsInfoDisplayRequestAttributesContributor.java:42)
	at com.liferay.layout.type.controller.display.page.internal.layout.type.controller.DisplayPageLayoutTypeController.addAttributes(DisplayPageLayoutTypeController.java:267)
	at com.liferay.layout.type.controller.display.page.internal.layout.type.controller.DisplayPageLayoutTypeController.includeLayoutContent(DisplayPageLayoutTypeController.java:196)
	at com.liferay.portal.model.impl.LayoutImpl.includeLayoutContent(LayoutImpl.java:910)
	at com.liferay.headless.delivery.internal.dto.v1_0.util.DisplayPageRendererUtil.toHTML(DisplayPageRendererUtil.java:183)
	at com.liferay.headless.delivery.internal.resource.v1_0.StructuredContentResourceImpl.getStructuredContentRenderedContentByDisplayPageDisplayPageKey(StructuredContentResourceImpl.java:367)
	at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:179)
	at org.apache.cxf...

StructuredContentResourceTest.testGetStructuredContentRenderedContentByDisplayPageDisplayPageKey

java.lang.AssertionError: Thread Thread[http-nio-8080-exec-3,5,main] caught concurrent failure: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper, message=java.lang.RuntimeException: Unable to get class name from id 0
java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper, message=java.lang.RuntimeException: Unable to get class name from id 0
	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:60)
	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
	at org.apache.log4j.Category.callAppenders(Category.java:206)
	at org.apache.log4j.Category.forcedLog(Category.java:391)
	at org.apache.log4j.Category.log(Category.java:856)
	at com.liferay.portal.log.Log4jLogImpl.error(Log4jLogImpl.java:54)
	at com.liferay.portal.kernel.log.LogWrapper.error(LogWrapper.java:69)
	at com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper.getProblem(ExceptionMapper.java:31)
	at com.liferay.portal.vulcan.internal.jaxrs.exception.mapper.ExceptionMapper.getProblem(ExceptionMapper.java:27)
	at com.liferay.portal.vulcan.jaxrs.exception.mapper.BaseExceptionMapper.toResponse(BaseExceptionMapper.java:36)
	at org.apache.cxf.jaxrs.utils.ExceptionUtils.convertFaultToResponse(ExceptionUti...

liferay-continuous-integration · 2021-02-22T21:49:09Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2021-02-22T21:49:25Z

Pull request has been successfully forwarded to brianchandotcom#99056

liferay-continuous-integration · 2021-02-22T21:57:21Z

Jenkins Build:test-portal-source-format#5055
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#3811
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - ealonso > liferay-echo - PR#3811 - 2021-02-22[11:58:23]
Spira Jenkins Build:publish-spira-report#12042

liferay-continuous-integration · 2021-02-23T00:44:00Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#9171
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#3811
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - ealonso > liferay-echo - PR#3811 - 2021-02-22[11:58:20]
Spira Jenkins Build:publish-spira-report#14343

markocikos and others added 27 commits February 22, 2021 12:06

LPS-121900 Apply management toolbar based on Clay v3

32e4c07

LPS-107106 Simplify: less variable and better readability

8b9d3aa

LPS-107106 Should be the same problem

bee0301

LPS-107106 Update tests

e4bdf2c

LPS-127389 Unintentionally removed

a04eb79

LPS-127389 Cleaner readout of error message

132ae82

LPS-127389 Only add custom maven repo if user passes in credentials

8e2fd85

LPS-127389 Sort

45440ff

LPS-127389 Use StringBundler to cleanup test

d77759b

LPS-127389 add to stream

799e60c

LPS-127389 Source formatting

e2b9cc4

LPS-127389 Rename Test

baec705

LPS-127389 Add branch specific exclusion list

08a3634

LPS-127389 Move to Util class

2af85a4

LPS-127389 simplify

719e0b0

LPS-127389 Rename files

746a7a8

LPS-127389 Sort alphabetically

e95c59c

LPS-127389 Keep names consistent

aafcfeb

LPS-127389 Split into separate classes for clarity

9842c7f

LPS-127389 Create temp folder in each test instance

7cc677b

LPS-127389 More consistent var names

cffaf0c

LPS-127389 SF

625ed1e

LPS-127389 SF

f76e49a

LPS-125623 Remove app.properties for archived app

3915151

LPS-127800 Use instance id when editing web content display

c56f5bf

LPS-127800 Removes unnecessary call since we are doing it in the prev…

7ac3c1d

…ious line

ealonso mentioned this pull request Feb 22, 2021

Lps 127800 #3810

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Feb 22, 2021

ealonso added the ✅ Ready to Merge Pull request is ready and can be forwarded. label Feb 22, 2021

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 22, 2021

liferay-continuous-integration mentioned this pull request Feb 22, 2021

LPS-127800 Removes unnecessary call since we are doing it in the previous line brianchandotcom/liferay-portal#99056

Closed

liferay-continuous-integration closed this Feb 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-127800 Removes unnecessary call since we are doing it in the previous line #3811

LPS-127800 Removes unnecessary call since we are doing it in the previous line #3811

ealonso commented Feb 22, 2021

ealonso commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 22, 2021

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 23, 2021

LPS-127800 Removes unnecessary call since we are doing it in the previous line #3811

LPS-127800 Removes unnecessary call since we are doing it in the previous line #3811

Conversation

ealonso commented Feb 22, 2021

ealonso commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 22, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 49 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 22, 2021

liferay-continuous-integration commented Feb 23, 2021