Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-140136 Preview draft action needs update permission #6024

Closed
wants to merge 3 commits into from
Closed

LPS-140136 Preview draft action needs update permission #6024

wants to merge 3 commits into from

Conversation

jkappler
Copy link

@jkappler jkappler commented Oct 2, 2021

  • LPS-140136 Don't show preview and discard draft actions when the user doesn't have update permissions for the page
  • LPS-140136 Remove unused configurationPid

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jkappler jkappler added the ✅ Ready to Merge Pull request is ready and can be forwarded. label Oct 2, 2021
@jkappler
Copy link
Author

jkappler commented Oct 2, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: de3019809c2ad1381f92b43f0f1d67e21c107c5d

Sender Branch:

Branch Name: LPS-140136
Branch GIT ID: 5f8ebbbf323fb92b1ac7d418062911ab683fa0ac

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 20 out of 27 jobs passed in 1 hour 41 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1307401_701

Base Branch:

Branch Name: master
Branch GIT ID: de3019809c2ad1381f92b43f0f1d67e21c107c5d

Upstream Comparison:

Branch GIT ID: 7e712ec68e0d2772f962aad1881ce6d39c5a72bf
Jenkins Build URL: Acceptance Upstream DXP (master) #2379

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 20 out of 27 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #7333
      clean-up-java-processes:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
[stopwatch] [run.batch.test.setup: 29:01.258 sec]
     [echo] run.batch.test.action.start.timestamp: 10-02-2021 08:48:32:192 PDT
     [echo] Checking for baseline log files.
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/util-bridges-8.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 8.1.2
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/util-java-6.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 6.0.6
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/util-slf4j-6.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 6.0.6
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/util-taglib-8.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 8.1.1
[beanshell] 
[stopwatch] [run.batch.test.action: 9.345 sec]
     [echo] Semantic versioning is incorrect.
      [get] Getting: http://test-1-27/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/7333//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20211002084841537.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20211002084841537.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null368755464.properties
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
    Job Results:

    75 Tests Passed.
    17 Tests Failed.

    5. ...
    Click here for more failures.

@liferay-continuous-integration
Copy link
Collaborator

@jkappler
Copy link
Author

jkappler commented Oct 2, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 21 out of 28 jobs passed in 2 hours 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2eda14f5729cad6e8e293b43bb870181006101d0

Upstream Comparison:

Branch GIT ID: 2eda14f5729cad6e8e293b43bb870181006101d0
Jenkins Build URL: Acceptance Upstream DXP (master) #2383

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 21 out of 28 jobs PASSED
21 Successful Jobs:
For more details click here.

Failures unique to this pull:

  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
    Job Results:

    69 Tests Passed.
    11 Tests Failed.

    5. ...
    Click here for more failures.
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
    Job Results:

    67 Tests Passed.
    13 Tests Failed.

    5. ...
    Click here for more failures.

@liferay-continuous-integration
Copy link
Collaborator

@Tim-Cao
Copy link

Tim-Cao commented Oct 4, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 011b8bb2a6354673d301f140ebaf9698cdbb9b9a

Sender Branch:

Branch Name: LPS-140136
Branch GIT ID: 972f91eb106d58c133d5a505aae5fadfb730ed67

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 22 out of 28 jobs passed in 2 hours 6 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_477

Base Branch:

Branch Name: master
Branch GIT ID: 011b8bb2a6354673d301f140ebaf9698cdbb9b9a

Upstream Comparison:

Branch GIT ID: 2eda14f5729cad6e8e293b43bb870181006101d0
Jenkins Build URL: Acceptance Upstream DXP (master) #2383

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 22 out of 28 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
    Job Results:

    67 Tests Passed.
    12 Tests Failed.

    5. ...
    Click here for more failures.
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
    Job Results:

    68 Tests Passed.
    13 Tests Failed.

    5. ...
    Click here for more failures.
Failures in common with acceptance upstream results at 2eda14f:
  1. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
    Job Results:

    70 Tests Passed.
    69 Tests Failed.

    5. ...
  2. ...

@liferay-continuous-integration
Copy link
Collaborator

@Tim-Cao
Copy link

Tim-Cao commented Oct 4, 2021

ci:reevaluate:1257401_477

@liferay-continuous-integration
Copy link
Collaborator

CI is reevaluating the build with build ID: 1257401_477 against the latest valid upstream results.

@liferay-continuous-integration
Copy link
Collaborator

Unable to reevaluate previous pull request result. Please wait for this acceptance upstream build to complete, and attempt reevaluation again with the CI command: 

ci:reevaluate:1257401_477

@Tim-Cao
Copy link

Tim-Cao commented Oct 5, 2021

See #6046

@Tim-Cao
Copy link

Tim-Cao commented Oct 5, 2021

ci:close

@jkappler jkappler deleted the LPS-140136 branch November 16, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
3 participants
@jkappler @liferay-continuous-integration @Tim-Cao