LPS-142436 | master #6474
Closed
LPS-142436 | master #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ozysouza
commented
Nov 18, 2021
...tional/com/liferay/portalweb/tests/enduser/wem/layout/widgetpage/WidgetPagesUseCase.testcase
Outdated
Show resolved
Hide resolved
Tim-Cao
reviewed
Nov 19, 2021
portal-web/test/functional/com/liferay/portalweb/paths/portlet/sitepages/SitePages.path
Outdated
Show resolved
Hide resolved
portal-web/test/functional/com/liferay/portalweb/macros/ManagementBar.macro
Outdated
Show resolved
Hide resolved
portal-web/test/functional/com/liferay/portalweb/macros/layout/sitepage/Page.macro
Outdated
Show resolved
Hide resolved
portal-web/test/functional/com/liferay/portalweb/paths/portlet/sitepages/SitePages.path
Outdated
Show resolved
Hide resolved
portal-web/test/functional/com/liferay/portalweb/macros/layout/pageeditor/PageEditor.macro
Outdated
Show resolved
Hide resolved
...est/functional/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesAdmin.testcase
Outdated
Show resolved
Hide resolved
...est/functional/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesAdmin.testcase
Outdated
Show resolved
Hide resolved
...est/functional/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesAdmin.testcase
Outdated
Show resolved
Hide resolved
...est/functional/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesAdmin.testcase
Outdated
Show resolved
Hide resolved
...est/functional/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesAdmin.testcase
Outdated
Show resolved
Hide resolved
Tim-Cao
added
🛠 Changes Required
…and modify effected cases
Hi @Tim-Cao, PR updated following your comments and conflicts solved. Would you mind run the SF locally to see if everything is okay? I don't know why but my source format is not working today, I've let a wrong formatation on porpuse to check and the build got successeful even though it should fail then I did the SF manually and I maybe missed something. Additionally I added PagesAdminWithStaging in the PR. Thank you |
|
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-142436 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#1005 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-echo#6474 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#3455 |
Tim-Cao
added
🛑 On Hold
Tim-Cao
reviewed
Nov 23, 2021
...l/com/liferay/portalweb/macros/sitenavigation/sitenavigationmenu/NavigationMenusWidget.macro
Outdated
Show resolved
Hide resolved
...st/functional/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesFinder.testcase
Show resolved
Hide resolved
...st/functional/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesFinder.testcase
Show resolved
Hide resolved
...nal/com/liferay/portalweb/tests/enduser/wem/layout/pagesadmin/PagesAdminWithStaging.testcase
Outdated
Show resolved
Hide resolved
Tim-Cao
added
🛠 Changes Required
|
Hi @ozysouza, see changes 8e1cd27...56b59f5 |
|
ci:close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.liferay.com/browse/LPS-142436
cc @david-gutierrez-mesa
cc @Tim-Cao