LPP-45812 | LPS-157509: Element placement on drop zones are not retained after fragment modification

[thienquach87]

@liferay-echo,
I have updated source to fix this issue relating to drop zones.
Currently, it works well with these simple cases. However, we have an issue with the workflow that is used to restore these deletedLayoutStructureItems. There is a condition used to check a deletedLayoutStructureItem whether restored or not. But this condition is not correct for all cases. I think we can try to verify by tagId(for example: =>tagId is "drop-zone01", and each tagId is required an unique value) instead of the current condition, or remove restoring layout flow.

Refer to condition code

[liferay-echo]

Thank you for submitting this PR. 👏

Make sure it follows the Echo Pull Request Template if you haven't already done so.

Learn more about it here.

[liferay-continuous-integration]

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

[ealonso]

Just started reviewing :)

Sent from GH.

[ealonso]

Hey @thienquach87,
Actually it is not a bug it is the expected behavior, I added more information to the jira ticket, please see the comment: https://issues.liferay.com/browse/LPS-157509?focusedCommentId=2737879&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-2737879

Regards,
Eudaldo.

[thienquach87]

Hello @ealonso
I did not see your comment when I access above link . Could you help re-check it?

Regards,
ThienQuach

[ealonso]

Hey @thienquach87,

It is restricted to liferay-staff, I'm going to copy it here:

It is not a bug, it is the expected behavior. Please see the documentation bug https://issues.liferay.com/browse/LRDOCS-10917
Actually the documentation is talking about an id or data-lfr-drop-zone-id and it is not supported, we are not taking it into account to render the drop zones. So, as you can see in the documentation draft:
"The drop zone has no id. This implies that the drop zones are rendered in order and cannot be rearranged."

[thienquach87]

Hello @ealonso,
I got it! Thank you for explaining this to me.

Regards,
ThienQuach