Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-132714 Upgrade ckeditor to v4.16.0-liferay.2 #1098

Closed
wants to merge 2 commits into from
Closed

LPS-132714 Upgrade ckeditor to v4.16.0-liferay.2 #1098

wants to merge 2 commits into from

Conversation

markocikos
Copy link
Collaborator

JIRA ticket: https://issues.liferay.com/browse/LPS-132714

@julien @jonmak08

In addition to ckeditor version increase, we are running yarn on modules in 159bb48.

Changelog:

🔧 Bug fixes

  • fix: remove unneeded styles (#176)
  • fix: update @clayui/css to latest and add more icons (#175)
  • fix: add null check (#168)

@markocikos
LPS-132714 Update yarn on dxp
159bb48
@markocikos
LPS-132714 Update liferay-ckeditor to v4.16.0-liferay.2
708cf54 
**Changes in this version**

[Full changelog](liferay/liferay-ckeditor@v4.16.0-liferay.1...v4.16.0-liferay.2)

### 🔧 Bug fixes

-   fix: remove unneeded styles ([\#176](liferay/liferay-ckeditor#176))
-   fix: update @clayui/css to latest and add more icons ([\#175](liferay/liferay-ckeditor#175))
-   fix: add null check ([\#168](liferay/liferay-ckeditor#168))
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e4162a50d26867da7ad6a4755c764eb1d565a531

Sender Branch:

Branch Name: LPS-132714
Branch GIT ID: 708cf547ede8a4dbab200db68d15b0dd91ae895b

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 38 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e4162a50d26867da7ad6a4755c764eb1d565a531

Upstream Comparison:

Branch GIT ID: e4162a50d26867da7ad6a4755c764eb1d565a531
Jenkins Build URL: Acceptance Upstream DXP (master) #1895

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@julien
Copy link

julien commented May 25, 2021

Hi @markocikos,

The change in package.json looks good to me, but as discussed on Slack, we should coordinate with @nhpatt to avoid conflicts in the yarn.lock file (additionally I think that the commit message is a little bit confusing because "Update yarn on dxp", could mean that we're actually updating yarn and not the yarn.lock file)

@javiergamarra
Copy link

It's Ok for my part, we agreed on committing it here, not going to send anything :)

@markocikos markocikos added the s-dxp One of the DXP squads should review this pull request (deprecated) label May 25, 2021
@julien
Copy link

julien commented May 25, 2021

@nhpatt ah ok, no worries then - sorry for the confusion.
I also had a look at the test failures and they don't see related.

@markocikos
Copy link
Collaborator Author

@john-co @manoelcyreno can you please take a look the failure, it looks unrelated.

The failing test looks wrong. I don't think we should be checking for height: 82px; in a functional test. This is something that can very easily change.

@john-co
Copy link

john-co commented May 25, 2021

@nkkwon could you take a look and analyze the failure?

@nkkwon
Copy link

nkkwon commented May 25, 2021

Just started reviewing :)

@nkkwon
Copy link

nkkwon commented May 25, 2021

Analysis Details
@markocikos

LocalFile.PortalSmokeUpgrade#ViewPortalSmokeArchive621021 - It looks like it's a flaky issue, has the same error occur in a recent acceptance run and looks like some other PR are being affected by it

@john-co
Copy link

john-co commented May 25, 2021

cc/ @vicnate5 see flaky PortalSmokeUpgrade#ViewPortalSmokeArchive621021 reported above.

@john-co
Copy link

john-co commented May 25, 2021

ci:test:relevant

@john-co
Copy link

john-co commented May 25, 2021

Trying relevant again so hopefully it passes and ready by morning. If not, ok to manually forward if test failure doesn't look related.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 0 out of 9 jobs passed

❌ ci:test:relevant - 0 out of 23 jobs passed in 5 hours 22 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1137401_6049

Base Branch:

Branch Name: master
Branch GIT ID: 734e2da945da23b3c43df517c8827aee92b7a6bb

Upstream Comparison:

Branch GIT ID: d7e7ba5015c0d51fc448b029c7f1ddff282151a7
Jenkins Build URL: Acceptance Upstream DXP (master) #1902

ci:test:stable - 0 out of 9 jobs PASSED
ci:test:relevant - 0 out of 23 jobs PASSED

23 Failed Jobs:

For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0
    Job Results:

    0 Tests Passed.
    0 Tests Failed.

    Build was aborted
  4. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
    Job Results:

    0 Tests Passed.
    0 Tests Failed.

    Build was aborted
  6. ...

For upstream results, click here.

Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@markocikos
Copy link
Collaborator Author

markocikos commented May 26, 2021 •
edited

I'm a bit worried about forwarding manually, since we are updating a lot of dependencies in this PR. First CI fail was very early on, and second one was aborted build. I'll try forwarding one more time.

@markocikos
Copy link
Collaborator Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@javiergamarra
Copy link

I can split updating the package.json in another PR if it fails again.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 4 hours 38 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 26c6bc1b470b21c0ea00632554536f3a9ad8e17b

Upstream Comparison:

Branch GIT ID: 26c6bc1b470b21c0ea00632554536f3a9ad8e17b
Jenkins Build URL: Acceptance Upstream DXP (master) #1904

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#102400
Console

@liferay-continuous-integration
Copy link
Collaborator

@julien julien mentioned this pull request Jul 6, 2021
Closed
@markocikos markocikos deleted the LPS-132714 branch January 21, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien julien julien approved these changes

@jonmak08 jonmak08 Awaiting requested review from jonmak08

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success s-dxp One of the DXP squads should review this pull request (deprecated)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@markocikos @liferay-continuous-integration @julien @javiergamarra @john-co @nkkwon