Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-137955 | Fix test WYSIWYGUsecase#CanEditTextInPreviewSourceContent #1460

Closed
wants to merge 3 commits into from

Conversation

john-co
Copy link

@john-co john-co commented Sep 13, 2021

Background
Test has been failing due to not having an existing web content to edit beforehand. Fix is to add a web content in setup phase of the test.

Test Plan

  • Make sure test passes and can edit text in preview source content view

JIRA Ticket:
https://issues.liferay.com/browse/LPS-137955

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@john-co john-co changed the title LPS-137955 | master LPS-137955 | Fix test WYSIWYGUsecase#CanEditTextInPreviewSourceContent Sep 13, 2021
@john-co
Copy link
Author

john-co commented Sep 13, 2021

ci:test:sf

@john-co
Copy link
Author

john-co commented Sep 13, 2021

ci:test:frontend

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8576715933e3e20cd99be22e4ac036bce30aedae

Sender Branch:

Branch Name: LPS-137955
Branch GIT ID: 73480eda8ee310c45363c8242332129660dbdbdb

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8576715933e3e20cd99be22e4ac036bce30aedae

Sender Branch:

Branch Name: LPS-137955
Branch GIT ID: 73480eda8ee310c45363c8242332129660dbdbdb

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@john-co
Copy link
Author

john-co commented Sep 13, 2021

ci:stop

@john-co john-co marked this pull request as draft September 14, 2021 00:44
@john-co
Copy link
Author

john-co commented Sep 14, 2021

ci:test:frontend:nocompile

@liferay-continuous-integration
Copy link
Collaborator

The test will run with a prebuilt bundle..

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:frontend - 5 out of 7 jobs passed in 45 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1287401_264

Base Branch:

Branch Name: master
Branch GIT ID: 8576715933e3e20cd99be22e4ac036bce30aedae

Upstream Comparison:

Branch GIT ID: 085840d3115742ca246067fb022ccf3aa25fa641
Jenkins Build URL: Acceptance Upstream DXP (master) #2311

ci:test:frontend - 5 out of 7 jobs PASSED
5 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 085840d:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
    Job Results:

    1482 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #4982
      1. com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning[/apps/analytics/analytics-message-sender-api]
        java.lang.AssertionError:   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
        = ================================================== ========== ========== ========== ========== ==========
        * com.liferay.analytics.message.sender.model.listener MAJOR      1.1.0      1.1.0      2.0.0      VERSION INCREASE REQUIRED
        	>   class      com.liferay.analytics.message.sender.model.listener.BaseEntityModelListener
        		-   method     onBeforeUpdate(com.liferay.portal.kernel.model.BaseModel)
        			-   return     void
        		+   method     onBeforeUpdate(com.liferay.portal.kernel.model.BaseModel,com.liferay.portal.kernel.model.BaseModel)
        			+   return     void
        [Baseline Warning] Bundle Version Change Recommended: 6.0.0
        
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertFalse(Assert.java:64)
        at com.liferay.semantic.versioning.SemanticVersioningTest.testSemanticVersioning(SemanticVersioningTest.java:82)
        at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at org.junit.in...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html><h5>Test bundle downloads:</h5><ul><li><a href="https://files.liferay.com/private/bundles/test-1-28/jobs/test-portal-acceptance-pullrequest(master)/builds/264/liferay-portal-bundle-tomcat.tar.gz">liferay-portal-bundle-tomcat.tar.gz</a> (mirrors: <a href="http://mirrors.dlc.liferay.com/files.liferay.com/private/bundles/test-1-28/jobs/test-portal-acceptance-pullrequest(master)/builds/264/liferay-portal-bundle-tomcat.tar.gz">dlc</a>, <a href="http://mirrors.lax.liferay.com/files.liferay.com/private/bundles/test-1-28/jobs/test-portal-acceptance-pullrequest(master)/builds/264/liferay-portal-bundle-tomcat.tar.gz">lax</a>)</li></ul>
        

@liferay-continuous-integration
Copy link
Collaborator

@john-co
Copy link
Author

john-co commented Sep 14, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 35855e821e79b9ca7478083359acbcd0cd5b8aba

Sender Branch:

Branch Name: LPS-137955
Branch GIT ID: 7d3373e9c389cebd982dd162772788551d43f614

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#107141
Console

@liferay-continuous-integration
Copy link
Collaborator

This pull request already has open forwarded pull request(s):
brianchandotcom#107141

Pull request will not be forwarded to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants