New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-152229 Replace and deprecate listSelect
with new getSelectedOptionValues
utility
#2199
Conversation
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: listSelect 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#2507 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#2199 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - kresimir-coko > liferay-frontend - PR#2199 - 2022-05-06[01:56:40] Testray Importer:publish-testray-report#9316 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#2050 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#2199 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#2199 - 2022-05-06[01:56:40] Testray Importer:publish-testray-report#4916 |
ci:test:relevant |
Jenkins Build:test-portal-acceptance-pullrequest(master)#2695 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#2199 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#2199 - 2022-05-06[04:17:40] Testray Importer:publish-testray-report#7193 |
ci:test:relevant |
Jenkins Build:test-portal-acceptance-pullrequest(master)#359 Jenkins Report:jenkins-report.html Jenkins Suite:functional Pull Request:liferay-frontend#2199 Testray Routine:EE Pull Request Testray Build:[master] ci:test:functional - kresimir-coko > liferay-frontend - PR#2199 - 2022-05-12[04:00:37] Testray Importer:publish-testray-report#853 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#2766 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#2199 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kresimir-coko > liferay-frontend - PR#2199 - 2022-05-12[03:00:17] Testray Importer:publish-testray-report#7359 |
ci:reevaluate:1257401_2766 |
CI is reevaluating the build with build ID: |
ci:test:acceptance:functional |
❌ ci:test:functional - 0 out of 1 jobs passed in 2 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 93720ccdbebdeb15eaa62d4d0241ab6909147ede ci:test:functional - 0 out of 1 jobs PASSED1 Failed Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here.Test bundle downloads:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#380 Jenkins Report:jenkins-report.html Jenkins Suite:functional Pull Request:liferay-frontend#2199 Testray Routine:EE Pull Request Testray Build:[master] ci:test:functional - kresimir-coko > liferay-frontend - PR#2199 - 2022-05-13[00:33:14] Testray Importer:publish-testray-report#899 |
|
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#117395 |
Overview
listSelect
is a utility that accepts a<select>
element, and an optionaldelimiter
argument. It returns a CSV string consisting of values of<option>
elements that are children of the<select>
element.I've decided to rename this utility as it doesn't do what the name
listSelect
suggests but instead it gets the selected options inside the provided select element.🧪 This util can be tested by dragging the
Documents & Media
portlet onto the landing page and going to its Configuration. Once there, click Save and the util will be invoked.