Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-120294 Allow changing existing images in CKEditor using the Image Dialog #352

Closed
wants to merge 1 commit into from
Closed

LPS-120294 Allow changing existing images in CKEditor using the Image Dialog #352

wants to merge 1 commit into from

Conversation

jbalsas
Copy link

@jbalsas jbalsas commented Sep 2, 2020 •
edited

Issue discovered doing a review with Tarik from Echo about the migration from AlloyEditor to CKEditor.

Steps to Reproduce

  • Navigate to Content & Data > Web Content
  • Use the Image button to add an image previously uploaded to the Document Library
  • Double click on the image element to show the image edition dialog
  • Click on the Browse Server button to pick a different image
  • Select a different image

image

The problem
We switched from image to image2 as our default CKEditor plugin for images. Because of that, our logic to bind the Browse Button to execute our own command fails.

The fix
Add the necessary additional logic to cover the image2 plugin use case

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jbalsas
Copy link
Author

jbalsas commented Sep 2, 2020

ci:test:sf

@jbalsas
Copy link
Author

jbalsas commented Sep 2, 2020

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8de11d8e9d6424a9dc9ae8f371839e58263dc111

Sender Branch:

Branch Name: LPS-120294
Branch GIT ID: 0e8d174a70383c841aca0da264955da1691cc33d

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#3083
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#352
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - jbalsas > liferay-frontend - PR#352 - 2020-09-02[03:50:28]
Spira Jenkins Build:publish-spira-report#8045

carloslancha
carloslancha approved these changes Sep 2, 2020
View reviewed changes
Copy link

@carloslancha carloslancha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

❌ ci:test:relevant - 44 out of 46 jobs passed in 1 hour 57 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8de11d8e9d6424a9dc9ae8f371839e58263dc111

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: df1236053a2097d63e354600635a9bf8b08e5a99

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 44 out of 46 jobs PASSED
44 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #289464
           [exec] * What went wrong:
     [exec] Could not write to file '/opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2020-09-02-05-15-22.html'.
     [exec] > java.lang.NullPointerException (no error message)
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.UncheckedIOException: Could not write to file '/opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2020-09-02-05-15-22.html'.
     [exec] 	at org.gradle.internal.IoActions$TextFileWriterIoAction.execute(IoActions.java:152)
     [exec] 	at org.gradle.internal.IoActions$TextFileWriterIoAction.execute(IoActions.java:127)
     [exec] 	at org.gradle.internal.IoActions.writeTextFile(IoActions.java:45)
     [exec] 	at org.gradle.reporting.HtmlReportRenderer$DefaultHtmlReportContext.renderHtmlPage(HtmlReportRenderer.java:120)
     [exec] 	at org.gradle.reporting.HtmlReportRenderer$1.render(HtmlReportRenderer.java:61)
     [exec] 	at org.gradle.reporting.HtmlReportRenderer$1.render(HtmlReportRenderer.java:58)
     [exec] 	at org.gradle.reporting.HtmlReportRenderer.render(HtmlReportRenderer.java:42)
     [exec] 	at org.gradle.reporting.HtmlReportRenderer.renderSinglePage(HtmlReportRenderer.java:58)
     [exec] 	at org.gradle.profile.ProfileReportRenderer.writeTo(ProfileReportRenderer.java:32)
     [exec] 	at org.gradle.profile.ReportGeneratingProfileListener.buildFinished(ReportGeneratingProfileListener.java:50)
     [exec] 	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
     [exec] 	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
     [exec] 	at org.gradle.internal.event.DefaultListenerManager$ListenerDetails.dispatch(DefaultListenerManager.java:382)
     [exec] 	at org.gradle.internal.event.DefaultListenerManager$ListenerDetails.dispatch(DefaultListenerManager.java:364)
     [exec] 	at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:58)
     [exec] 	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast$ListenerDispatch.dispatch(DefaultListenerManager.java:352)
     [exec] 	at org.gradle.internal.event.DefaultListenerManager$EventBroadcast.dispatch(DefaultListenerManager.java:163)

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#6990
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#352
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#352 - 2020-09-02[03:50:56]
Spira Jenkins Build:publish-spira-report#4426

@carloslancha
Copy link

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 46 out of 46 jobs passed in 1 hour 49 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8de11d8e9d6424a9dc9ae8f371839e58263dc111

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: df1236053a2097d63e354600635a9bf8b08e5a99

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 46 out of 46 jobs PASSED
46 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7529
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#352
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - jbalsas > liferay-frontend - PR#352 - 2020-09-02[06:15:45]
Spira Jenkins Build:publish-spira-report#8080

@jbalsas
Copy link
Author

jbalsas commented Sep 2, 2020

I see pair of approvals, so Imma ship it!

@jbalsas
Copy link
Author

jbalsas commented Sep 2, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Sep 2, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#93662

@jbalsas jbalsas deleted the LPS-120294 branch October 30, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien julien julien approved these changes

@carloslancha carloslancha carloslancha approved these changes

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success forwarding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbalsas @liferay-continuous-integration @carloslancha @julien