Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-122765 Fix semantic versioning issue with frontend token definition api #457

Closed
wants to merge 1 commit into from
Closed

LPS-122765 Fix semantic versioning issue with frontend token definition api #457

wants to merge 1 commit into from

Conversation

john-co
Copy link

@john-co john-co commented Oct 28, 2020

This updates the package info to the recommended version to fix failing semantic versioning test described in https://issues.liferay.com/browse/LPS-122765

@john-co john-co requested a review from izaera October 28, 2020 20:02
@john-co
Copy link
Author

john-co commented Oct 28, 2020

ci:test:sf

@john-co
Copy link
Author

john-co commented Oct 28, 2020

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2cf4f631a70f94de44fb7a017742f3eb822702a4

Sender Branch:

Branch Name: LPS-122765
Branch GIT ID: 356d2fb4c5a46675bfa6d9a4cccc39ee7d4dc730

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4689
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#457
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - john-co > liferay-frontend - PR#457 - 2020-10-28[13:03:35]
Spira Jenkins Build:publish-spira-report#10299

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 22 jobs passed in 1 hour 27 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2cf4f631a70f94de44fb7a017742f3eb822702a4

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 424ab1158c689b11bc409031cffca77c71b5b194

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 22 jobs PASSED
22 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#3857
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#457
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - john-co > liferay-frontend - PR#457 - 2020-10-28[14:43:00]
Spira Jenkins Build:publish-spira-report#12237

@jbalsas
Copy link

jbalsas commented Oct 29, 2020

Hey @john-co, I'm not sure this makes sense... @izaera changed this recently liferay@27c80f1#diff-20a00663edca54e96364a5e6407aee9228677ebb12f983f36b746e5a66087753 because there were changes in the package...

@izaera, can you figure out what happened here?

@jbalsas
Copy link

jbalsas commented Oct 29, 2020

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 22 jobs passed in 1 hour 50 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 19d7b9fb5d04555a231e3f1068c524ac9abde94a

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 424ab1158c689b11bc409031cffca77c71b5b194

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 22 jobs PASSED
22 Successful Jobs:
For more details click here.

@jbalsas
Copy link

jbalsas commented Oct 29, 2020

Okay, I see now that this is setting to 1.0.0 and in #458 we'll need 1.1.0, so maybe we can just get that done there.

@jbalsas jbalsas mentioned this pull request Oct 29, 2020
Closed
@jbalsas
Copy link

jbalsas commented Oct 29, 2020

Asked @victorg1991 to do it in #458. Closing here so we don't have conflicting PRs in flight.

@jbalsas jbalsas closed this Oct 29, 2020
@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#8395
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#457
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - john-co > liferay-frontend - PR#457 - 2020-10-29[01:25:16]
Spira Jenkins Build:publish-spira-report#6435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaera izaera Awaiting requested review from izaera

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-co @liferay-continuous-integration @jbalsas