LPS-113582|LPS-113583 Replaces the usages of Liferay.Notification and Liferay.Notice with Liferay.Util.openToast
#5
Conversation
…he given string is a HTML or not, uses a property for using `title` and `message ` as HTML in openToast utility. From: jbalsas#2179 (comment)
…and use directly `dangerouslySetInnerHTML` on Text component
… Liferay.Util.openToast
…penToast` Found usages via: `git grep '\bLiferay\.Notification\b'` `git grep liferay-notification`
Usages were found running `git grep '\bLiferay\.Notice\b'` `git grep liferay-notice` `Liferay.Util.openToast` utility was created for opening toasts and considering that Notice usages are for opening dismissible toasts, I could replace directly
…of Liferay.Notice AUI component and Liferay.Notice usages were replaced with `openToast` and ClayAlerts doesn't have animations
…s defined in whole file, these default values aren't needed
`React will automatically append a “px” suffix to certain numeric inline style properties.` From: https://reactjs.org/docs/dom-elements.html
… with the counter equal 1
…ring markup. For some cases in JSPs, HTML strings are being passed to openToast.
…he given string is a HTML or not, uses a property for using `title` and `message ` as HTML in openToast utility. From: jbalsas#2179 (comment)
…and use directly `dangerouslySetInnerHTML` on Text component
Early this property was being used for handling the instance of the Liferay.Notice component but now it's unnecessary
…in and wasn't using it. However, it was using `aui-alert` but not declaring it. `liferay-notice` depends on `aui-alert` and I'm assuming that it was working due to this
…ser don't pass the title/message value React will not throw an error trying to render undefined
… For avoiding breaking changes
… use `messageType` and `titleType` for handling toast contents
Apparently another module was calling `plugin` module and It was working in the past due to this and this dep wasn't described on the `liferay-session` module. Adding as a dependency of `liferay-session` solves the problem
…sion` In some cases, apparently depending on the hardware, `aui-component` is not being loaded causing an error not localizing `A.component` on session AUI component
|
ci:test:relevant |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-113582-LPS-113583 1 Successful Jobs:For more details click here. |
|
ci:test:bundle |
|
[unrelated]
[possibly unrelated]
|
liferay-continuous-integration
added
ci:test:bundle - success
and removed
ci:test:bundle - pending
labels
✔️ ci:test:bundle - 1 out of 1 jobs passed in 37 minutesClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private ci:test:bundle - 1 out of 1 jobs PASSEDFor more details click here.Test bundle downloads:
|
|
@rodrigocunhaa , I think the failng kaleoforms test is unrelated. The behavior seems to be reproducible on test server test-6-1-2 at GIT ID: a5641e2. There is no success message after importing a workflow definition. I didn't see this error message on testray history though. Was this recently fixed? |
|
@wincent , I'm able to reproduce the failing test behavior on our test server so the failing tests look unrelated. Reviewed. Test failures are unrelated. ✔️ Seeing the amount of tests run here, there's no need to retest. |
|
Hi @john-co , It's actually a bug. I'll open the ticket and quarantine this test. Thanks! |
|
So, there are 303 comments (the majority of them are bot interaction, I think) on this PR and its 5 previous incarnations). I'll be honest and confess that I do not have the stomach to look over it all with a magnifying glass again, but it seems ok based on a quick skim. Given that the test failures are confirmed to be unrelated, I am going to try a manual forward of this. Last call for objections, anyone? (especially @jbalsas, who commented previously) because soon this will be gone. If it turns out that that's a mistake, we can revert. |
|
Manual forward is here: brianchandotcom#90226 |
|
Well...
It definitely looks a bit daunting, all those commits for such a relatively small diff change... |
|
LGTM overall... changes in In any case let's get this in and see if we live to fight another day 😉 |
It's a common pattern. Evidently I am bad at giving review feedback, and people are bad at understanding it. |
Forwarded here from wincent#309, where it was stuck in CI hell. Let's see if we have any better luck over here.
Original description:
cc @diegonvs @jbalsas